Roll zlib #20119

stuartmorgan · 2020-07-29T17:19:32Z

Description

Picks up the buildroot change to roll zlib to the latest version from
Chromium.

Related Issues

No specific issue, but is needed to roll ANGLE, and will be useful for various future work (macOS ARM builds, UWP builds, etc.)

Tests

I added the following tests: None; not intended to change any functionality.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the contributor guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the C++, Objective-C, Java style guides for the engine.
I read the tree hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change.

Picks up the buildroot change to roll zlib to the latest version from Chromium.

flutter-dashboard · 2020-07-29T19:53:05Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Hixie

* 4521162 Roll Skia from 39d1c1ebb607 to 3a608e5bc9d5 (1 revision) (flutter/engine#20101) * b265bd2 Roll Skia from 3a608e5bc9d5 to 620bfa3fffba (1 revision) (flutter/engine#20102) * 36c5f60 Roll Skia from 620bfa3fffba to 4866d0ad5f3c (1 revision) (flutter/engine#20104) * 06fef5e Enable lazy-async-stacks by-default in all modes (2) (flutter/engine#19270) * d71b11f Roll Fuchsia Linux SDK from ETPOTPepP... to ROYgzKMaF... (flutter/engine#20105) * 42e4ebf Roll Skia from 4866d0ad5f3c to c34efe0da102 (1 revision) (flutter/engine#20108) * 3a65b1a Roll Skia from c34efe0da102 to 8c7ecc1c06f4 (1 revision) (flutter/engine#20109) * ad99f5e Roll Skia from 8c7ecc1c06f4 to 4f587337c306 (1 revision) (flutter/engine#20110) * f0cc38f [web] Set correct defaults for text in canvas (flutter/engine#20067) * 02f9ed9 Roll Fuchsia Mac SDK from 5dM55hp8B... to hzo88TZzN... (flutter/engine#20113) * 34389f5 Roll Skia from 4f587337c306 to 96d6c6f04dcb (4 revisions) (flutter/engine#20114) * 49a40fa Enabled linting on engine.cc (flutter/engine#19981) * b955e15 Manual roll of Dart from 24c7666def...40fd1c456e (flutter/engine#20092) * 145ef60 Remove confusing logs (flutter/engine#20121) * 8fc3926 Roll Skia from 96d6c6f04dcb to 57d859edd3c4 (16 revisions) (flutter/engine#20126) * ec9e17c Roll zlib (flutter/engine#20119) * f288fe5 [web] Enable canvas measurement by default (flutter/engine#19924) * 8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968) * 5498add Roll Skia from 57d859edd3c4 to 994ce8cf2300 (1 revision) (flutter/engine#20129) * 9398bc4 Roll Skia from 994ce8cf2300 to 398c654ce7be (2 revisions) (flutter/engine#20133) * d3bc43e Roll Fuchsia Linux SDK from ROYgzKMaF... to d4pESQYnB... (flutter/engine#20132) * 4068918 Manual roll of Dart 40fd1c456e...7e8348f4ce (flutter/engine#20125) * 4c49e0b Manual roll of Dart cb6ed67a73...7e8348f4ce (flutter/engine#20135) * 4a3688e Roll Skia from 398c654ce7be to a4bbc9d8ec4f (1 revision) (flutter/engine#20136) * b3c6fd3 Roll Fuchsia Mac SDK from hzo88TZzN... to 3XwiR_wVO... (flutter/engine#20137) * adb5986 Manual roll of Dart 03e4737f31...cb6ed67a73 (flutter/engine#20138) * 941c442 Add ALERT SoundType enum value (flutter/engine#20139) * 19368ef Fix dartdocs of dart:ui (flutter/engine#20140) * 9dd3d2e Roll Skia from a4bbc9d8ec4f to 94cefeff50d2 (1 revision) (flutter/engine#20141) * 0fdb141 Roll Dart SDK from 03e4737f3115 to 59600f2b46ef (54 revisions) (flutter/engine#20143) * 97d6ee2 Roll Skia from 94cefeff50d2 to 5ba6534884d9 (2 revisions) (flutter/engine#20146) * da3d495 Roll Dart SDK from 59600f2b46ef to 04f4272546af (5 revisions) (flutter/engine#20147) * 8229df8 Roll Skia from 5ba6534884d9 to e393c61a1563 (1 revision) (flutter/engine#20148) * 8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle (flutter/engine#20107) * 27b61e7 Roll ANGLE to pick up warning fixes (flutter/engine#19105) * 146d504 Roll Skia from e393c61a1563 to 3136789972ea (5 revisions) (flutter/engine#20150) * 841b391 Roll Dart SDK from 04f4272546af to e87cb96bb89c (7 revisions) (flutter/engine#20152) * e9334c9 Roll Skia from 3136789972ea to 5f2b2d6dc691 (5 revisions) (flutter/engine#20153) * f2b02d8 [iOS] Fixes text input plugin crash (flutter/engine#20127) * 3ed5893 Roll Skia from 5f2b2d6dc691 to 8cc118dce813 (2 revisions) (flutter/engine#20154) * 7c5162e Roll Fuchsia Mac SDK from 3XwiR_wVO... to T2xc0OuiK... (flutter/engine#20155) * e23e477 Lint fixes for fml, tools subdirs (flutter/engine#19990) * f620eac Roll Dart SDK from e87cb96bb89c to bd528bfbd69d (8 revisions) (flutter/engine#20158) * e1c9673 Fix targets in build_fuchsia_artifacts (flutter/engine#19794) * c134e16 add information collection for safari bots (flutter/engine#20123) * ee4d50c Revert "Enable lazy-async-stacks by-default in all modes (2) (#19270)" (flutter/engine#20165) * 357b155 Roll Fuchsia Linux SDK from d4pESQYnB... to d_5wDVmBd... (flutter/engine#20161) * a6cd3eb Fix lint errors in lib/ui (flutter/engine#19988) * 280bbfc This makes the lint script use multiprocessing to speed it up. (flutter/engine#19987)

* 4521162 Roll Skia from 39d1c1ebb607 to 3a608e5bc9d5 (1 revision) (flutter/engine#20101) * b265bd2 Roll Skia from 3a608e5bc9d5 to 620bfa3fffba (1 revision) (flutter/engine#20102) * 36c5f60 Roll Skia from 620bfa3fffba to 4866d0ad5f3c (1 revision) (flutter/engine#20104) * 06fef5e Enable lazy-async-stacks by-default in all modes (2) (flutter/engine#19270) * d71b11f Roll Fuchsia Linux SDK from ETPOTPepP... to ROYgzKMaF... (flutter/engine#20105) * 42e4ebf Roll Skia from 4866d0ad5f3c to c34efe0da102 (1 revision) (flutter/engine#20108) * 3a65b1a Roll Skia from c34efe0da102 to 8c7ecc1c06f4 (1 revision) (flutter/engine#20109) * ad99f5e Roll Skia from 8c7ecc1c06f4 to 4f587337c306 (1 revision) (flutter/engine#20110) * f0cc38f [web] Set correct defaults for text in canvas (flutter/engine#20067) * 02f9ed9 Roll Fuchsia Mac SDK from 5dM55hp8B... to hzo88TZzN... (flutter/engine#20113) * 34389f5 Roll Skia from 4f587337c306 to 96d6c6f04dcb (4 revisions) (flutter/engine#20114) * 49a40fa Enabled linting on engine.cc (flutter/engine#19981) * b955e15 Manual roll of Dart from 24c7666def...40fd1c456e (flutter/engine#20092) * 145ef60 Remove confusing logs (flutter/engine#20121) * 8fc3926 Roll Skia from 96d6c6f04dcb to 57d859edd3c4 (16 revisions) (flutter/engine#20126) * ec9e17c Roll zlib (flutter/engine#20119) * f288fe5 [web] Enable canvas measurement by default (flutter/engine#19924) * 8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968) * 5498add Roll Skia from 57d859edd3c4 to 994ce8cf2300 (1 revision) (flutter/engine#20129) * 9398bc4 Roll Skia from 994ce8cf2300 to 398c654ce7be (2 revisions) (flutter/engine#20133) * d3bc43e Roll Fuchsia Linux SDK from ROYgzKMaF... to d4pESQYnB... (flutter/engine#20132) * 4068918 Manual roll of Dart 40fd1c456e...7e8348f4ce (flutter/engine#20125) * 4c49e0b Manual roll of Dart cb6ed67a73...7e8348f4ce (flutter/engine#20135) * 4a3688e Roll Skia from 398c654ce7be to a4bbc9d8ec4f (1 revision) (flutter/engine#20136) * b3c6fd3 Roll Fuchsia Mac SDK from hzo88TZzN... to 3XwiR_wVO... (flutter/engine#20137) * adb5986 Manual roll of Dart 03e4737f31...cb6ed67a73 (flutter/engine#20138) * 941c442 Add ALERT SoundType enum value (flutter/engine#20139) * 19368ef Fix dartdocs of dart:ui (flutter/engine#20140) * 9dd3d2e Roll Skia from a4bbc9d8ec4f to 94cefeff50d2 (1 revision) (flutter/engine#20141) * 0fdb141 Roll Dart SDK from 03e4737f3115 to 59600f2b46ef (54 revisions) (flutter/engine#20143) * 97d6ee2 Roll Skia from 94cefeff50d2 to 5ba6534884d9 (2 revisions) (flutter/engine#20146) * da3d495 Roll Dart SDK from 59600f2b46ef to 04f4272546af (5 revisions) (flutter/engine#20147) * 8229df8 Roll Skia from 5ba6534884d9 to e393c61a1563 (1 revision) (flutter/engine#20148) * 8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle (flutter/engine#20107) * 27b61e7 Roll ANGLE to pick up warning fixes (flutter/engine#19105) * 146d504 Roll Skia from e393c61a1563 to 3136789972ea (5 revisions) (flutter/engine#20150) * 841b391 Roll Dart SDK from 04f4272546af to e87cb96bb89c (7 revisions) (flutter/engine#20152) * e9334c9 Roll Skia from 3136789972ea to 5f2b2d6dc691 (5 revisions) (flutter/engine#20153) * f2b02d8 [iOS] Fixes text input plugin crash (flutter/engine#20127) * 3ed5893 Roll Skia from 5f2b2d6dc691 to 8cc118dce813 (2 revisions) (flutter/engine#20154) * 7c5162e Roll Fuchsia Mac SDK from 3XwiR_wVO... to T2xc0OuiK... (flutter/engine#20155) * e23e477 Lint fixes for fml, tools subdirs (flutter/engine#19990) * f620eac Roll Dart SDK from e87cb96bb89c to bd528bfbd69d (8 revisions) (flutter/engine#20158) * e1c9673 Fix targets in build_fuchsia_artifacts (flutter/engine#19794) * c134e16 add information collection for safari bots (flutter/engine#20123) * ee4d50c Revert "Enable lazy-async-stacks by-default in all modes (2) (flutter#19270)" (flutter/engine#20165) * 357b155 Roll Fuchsia Linux SDK from d4pESQYnB... to d_5wDVmBd... (flutter/engine#20161) * a6cd3eb Fix lint errors in lib/ui (flutter/engine#19988) * 280bbfc This makes the lint script use multiprocessing to speed it up. (flutter/engine#19987)

Roll zlib

92723de

Picks up the buildroot change to roll zlib to the latest version from Chromium.

googlebot added the cla: yes label Jul 29, 2020

stuartmorgan marked this pull request as draft July 29, 2020 17:19

stuartmorgan mentioned this pull request Jul 29, 2020

Update third_party/zlib from Chromium flutter/buildroot#385

Merged

License updates

2015ad8

stuartmorgan marked this pull request as ready for review July 29, 2020 19:53

stuartmorgan requested review from chinmaygarde and Hixie July 29, 2020 19:53

Hixie approved these changes Jul 29, 2020

View reviewed changes

Merge branch 'master' into zlib-roll

8408a69

stuartmorgan merged commit ec9e17c into flutter:master Jul 29, 2020

stuartmorgan deleted the zlib-roll branch July 29, 2020 23:02

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to ec9e17c5cb29 (16 revisions) flutter/flutter#62535

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

92d609d

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 84642088637b (18 revisions) flutter/flutter#62538

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

a83e6cf

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 5498add1982d (19 revisions) flutter/flutter#62543

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

1573dd7

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 9398bc4b1f4c (20 revisions) flutter/flutter#62545

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

ee048e4

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 406891841fc2 (22 revisions) flutter/flutter#62554

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

eda4fa4

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 4c49e0b19663 (23 revisions) flutter/flutter#62561

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

a755a68

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 4a3688e47b98 (24 revisions) flutter/flutter#62563

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

4cffc7a

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 19368efcc371 (28 revisions) flutter/flutter#62566

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

b2d49b6

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 0fdb141433da (30 revisions) flutter/flutter#62569

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

efb4bd6

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 97d6ee26a614 (31 revisions) flutter/flutter#62573

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

9276f49

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to da3d4958b8e1 (32 revisions) flutter/flutter#62575

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

7822205

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 27b61e7ac8d6 (35 revisions) flutter/flutter#62581

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

7b56277

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 146d5049019a (36 revisions) flutter/flutter#62592

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

290dd50

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to f2b02d8fd53b (39 revisions) flutter/flutter#62607

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

204c3f5

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 7c5162e0a62c (41 revisions) flutter/flutter#62610

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

c179aa8

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to e23e4775ae62 (42 revisions) flutter/flutter#62617

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

8671b85

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to e1c9673bbb63 (44 revisions) flutter/flutter#62624

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

ec9e17c Roll zlib (flutter/engine#20119)

ed27a68

engine-flutter-autoroll mentioned this pull request Jul 31, 2020

Roll Engine from a9910e409c02 to c134e1658d56 (45 revisions) flutter/flutter#62629

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2020

ec9e17c Roll zlib (flutter/engine#20119)

528ce35

engine-flutter-autoroll mentioned this pull request Jul 31, 2020

Roll Engine from a9910e409c02 to 280bbfc763cf (49 revisions) flutter/flutter#62647

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2020

ec9e17c Roll zlib (flutter/engine#20119)

047c410

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Roll zlib #20119

Roll zlib #20119

stuartmorgan commented Jul 29, 2020

flutter-dashboard bot commented Jul 29, 2020

Hixie left a comment

Roll zlib #20119

Roll zlib #20119

Conversation

stuartmorgan commented Jul 29, 2020

Description

Related Issues

Tests

Checklist

Breaking Change

flutter-dashboard bot commented Jul 29, 2020

Hixie left a comment

Choose a reason for hiding this comment