Add missing MouseCursorPlugin destroy call #19968

jason-simmons · 2020-07-22T23:42:31Z

flutter-dashboard · 2020-07-22T23:42:34Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

fluttergithubbot · 2020-07-29T22:11:01Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Linux Web Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

Fixes flutter/flutter#61558

)

* 4521162 Roll Skia from 39d1c1ebb607 to 3a608e5bc9d5 (1 revision) (flutter/engine#20101) * b265bd2 Roll Skia from 3a608e5bc9d5 to 620bfa3fffba (1 revision) (flutter/engine#20102) * 36c5f60 Roll Skia from 620bfa3fffba to 4866d0ad5f3c (1 revision) (flutter/engine#20104) * 06fef5e Enable lazy-async-stacks by-default in all modes (2) (flutter/engine#19270) * d71b11f Roll Fuchsia Linux SDK from ETPOTPepP... to ROYgzKMaF... (flutter/engine#20105) * 42e4ebf Roll Skia from 4866d0ad5f3c to c34efe0da102 (1 revision) (flutter/engine#20108) * 3a65b1a Roll Skia from c34efe0da102 to 8c7ecc1c06f4 (1 revision) (flutter/engine#20109) * ad99f5e Roll Skia from 8c7ecc1c06f4 to 4f587337c306 (1 revision) (flutter/engine#20110) * f0cc38f [web] Set correct defaults for text in canvas (flutter/engine#20067) * 02f9ed9 Roll Fuchsia Mac SDK from 5dM55hp8B... to hzo88TZzN... (flutter/engine#20113) * 34389f5 Roll Skia from 4f587337c306 to 96d6c6f04dcb (4 revisions) (flutter/engine#20114) * 49a40fa Enabled linting on engine.cc (flutter/engine#19981) * b955e15 Manual roll of Dart from 24c7666def...40fd1c456e (flutter/engine#20092) * 145ef60 Remove confusing logs (flutter/engine#20121) * 8fc3926 Roll Skia from 96d6c6f04dcb to 57d859edd3c4 (16 revisions) (flutter/engine#20126) * ec9e17c Roll zlib (flutter/engine#20119) * f288fe5 [web] Enable canvas measurement by default (flutter/engine#19924) * 8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968) * 5498add Roll Skia from 57d859edd3c4 to 994ce8cf2300 (1 revision) (flutter/engine#20129) * 9398bc4 Roll Skia from 994ce8cf2300 to 398c654ce7be (2 revisions) (flutter/engine#20133) * d3bc43e Roll Fuchsia Linux SDK from ROYgzKMaF... to d4pESQYnB... (flutter/engine#20132) * 4068918 Manual roll of Dart 40fd1c456e...7e8348f4ce (flutter/engine#20125) * 4c49e0b Manual roll of Dart cb6ed67a73...7e8348f4ce (flutter/engine#20135) * 4a3688e Roll Skia from 398c654ce7be to a4bbc9d8ec4f (1 revision) (flutter/engine#20136) * b3c6fd3 Roll Fuchsia Mac SDK from hzo88TZzN... to 3XwiR_wVO... (flutter/engine#20137) * adb5986 Manual roll of Dart 03e4737f31...cb6ed67a73 (flutter/engine#20138) * 941c442 Add ALERT SoundType enum value (flutter/engine#20139) * 19368ef Fix dartdocs of dart:ui (flutter/engine#20140) * 9dd3d2e Roll Skia from a4bbc9d8ec4f to 94cefeff50d2 (1 revision) (flutter/engine#20141) * 0fdb141 Roll Dart SDK from 03e4737f3115 to 59600f2b46ef (54 revisions) (flutter/engine#20143) * 97d6ee2 Roll Skia from 94cefeff50d2 to 5ba6534884d9 (2 revisions) (flutter/engine#20146) * da3d495 Roll Dart SDK from 59600f2b46ef to 04f4272546af (5 revisions) (flutter/engine#20147) * 8229df8 Roll Skia from 5ba6534884d9 to e393c61a1563 (1 revision) (flutter/engine#20148) * 8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle (flutter/engine#20107) * 27b61e7 Roll ANGLE to pick up warning fixes (flutter/engine#19105) * 146d504 Roll Skia from e393c61a1563 to 3136789972ea (5 revisions) (flutter/engine#20150) * 841b391 Roll Dart SDK from 04f4272546af to e87cb96bb89c (7 revisions) (flutter/engine#20152) * e9334c9 Roll Skia from 3136789972ea to 5f2b2d6dc691 (5 revisions) (flutter/engine#20153) * f2b02d8 [iOS] Fixes text input plugin crash (flutter/engine#20127) * 3ed5893 Roll Skia from 5f2b2d6dc691 to 8cc118dce813 (2 revisions) (flutter/engine#20154) * 7c5162e Roll Fuchsia Mac SDK from 3XwiR_wVO... to T2xc0OuiK... (flutter/engine#20155) * e23e477 Lint fixes for fml, tools subdirs (flutter/engine#19990) * f620eac Roll Dart SDK from e87cb96bb89c to bd528bfbd69d (8 revisions) (flutter/engine#20158) * e1c9673 Fix targets in build_fuchsia_artifacts (flutter/engine#19794) * c134e16 add information collection for safari bots (flutter/engine#20123) * ee4d50c Revert "Enable lazy-async-stacks by-default in all modes (2) (#19270)" (flutter/engine#20165) * 357b155 Roll Fuchsia Linux SDK from d4pESQYnB... to d_5wDVmBd... (flutter/engine#20161) * a6cd3eb Fix lint errors in lib/ui (flutter/engine#19988) * 280bbfc This makes the lint script use multiprocessing to speed it up. (flutter/engine#19987)

* 4521162 Roll Skia from 39d1c1ebb607 to 3a608e5bc9d5 (1 revision) (flutter/engine#20101) * b265bd2 Roll Skia from 3a608e5bc9d5 to 620bfa3fffba (1 revision) (flutter/engine#20102) * 36c5f60 Roll Skia from 620bfa3fffba to 4866d0ad5f3c (1 revision) (flutter/engine#20104) * 06fef5e Enable lazy-async-stacks by-default in all modes (2) (flutter/engine#19270) * d71b11f Roll Fuchsia Linux SDK from ETPOTPepP... to ROYgzKMaF... (flutter/engine#20105) * 42e4ebf Roll Skia from 4866d0ad5f3c to c34efe0da102 (1 revision) (flutter/engine#20108) * 3a65b1a Roll Skia from c34efe0da102 to 8c7ecc1c06f4 (1 revision) (flutter/engine#20109) * ad99f5e Roll Skia from 8c7ecc1c06f4 to 4f587337c306 (1 revision) (flutter/engine#20110) * f0cc38f [web] Set correct defaults for text in canvas (flutter/engine#20067) * 02f9ed9 Roll Fuchsia Mac SDK from 5dM55hp8B... to hzo88TZzN... (flutter/engine#20113) * 34389f5 Roll Skia from 4f587337c306 to 96d6c6f04dcb (4 revisions) (flutter/engine#20114) * 49a40fa Enabled linting on engine.cc (flutter/engine#19981) * b955e15 Manual roll of Dart from 24c7666def...40fd1c456e (flutter/engine#20092) * 145ef60 Remove confusing logs (flutter/engine#20121) * 8fc3926 Roll Skia from 96d6c6f04dcb to 57d859edd3c4 (16 revisions) (flutter/engine#20126) * ec9e17c Roll zlib (flutter/engine#20119) * f288fe5 [web] Enable canvas measurement by default (flutter/engine#19924) * 8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968) * 5498add Roll Skia from 57d859edd3c4 to 994ce8cf2300 (1 revision) (flutter/engine#20129) * 9398bc4 Roll Skia from 994ce8cf2300 to 398c654ce7be (2 revisions) (flutter/engine#20133) * d3bc43e Roll Fuchsia Linux SDK from ROYgzKMaF... to d4pESQYnB... (flutter/engine#20132) * 4068918 Manual roll of Dart 40fd1c456e...7e8348f4ce (flutter/engine#20125) * 4c49e0b Manual roll of Dart cb6ed67a73...7e8348f4ce (flutter/engine#20135) * 4a3688e Roll Skia from 398c654ce7be to a4bbc9d8ec4f (1 revision) (flutter/engine#20136) * b3c6fd3 Roll Fuchsia Mac SDK from hzo88TZzN... to 3XwiR_wVO... (flutter/engine#20137) * adb5986 Manual roll of Dart 03e4737f31...cb6ed67a73 (flutter/engine#20138) * 941c442 Add ALERT SoundType enum value (flutter/engine#20139) * 19368ef Fix dartdocs of dart:ui (flutter/engine#20140) * 9dd3d2e Roll Skia from a4bbc9d8ec4f to 94cefeff50d2 (1 revision) (flutter/engine#20141) * 0fdb141 Roll Dart SDK from 03e4737f3115 to 59600f2b46ef (54 revisions) (flutter/engine#20143) * 97d6ee2 Roll Skia from 94cefeff50d2 to 5ba6534884d9 (2 revisions) (flutter/engine#20146) * da3d495 Roll Dart SDK from 59600f2b46ef to 04f4272546af (5 revisions) (flutter/engine#20147) * 8229df8 Roll Skia from 5ba6534884d9 to e393c61a1563 (1 revision) (flutter/engine#20148) * 8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle (flutter/engine#20107) * 27b61e7 Roll ANGLE to pick up warning fixes (flutter/engine#19105) * 146d504 Roll Skia from e393c61a1563 to 3136789972ea (5 revisions) (flutter/engine#20150) * 841b391 Roll Dart SDK from 04f4272546af to e87cb96bb89c (7 revisions) (flutter/engine#20152) * e9334c9 Roll Skia from 3136789972ea to 5f2b2d6dc691 (5 revisions) (flutter/engine#20153) * f2b02d8 [iOS] Fixes text input plugin crash (flutter/engine#20127) * 3ed5893 Roll Skia from 5f2b2d6dc691 to 8cc118dce813 (2 revisions) (flutter/engine#20154) * 7c5162e Roll Fuchsia Mac SDK from 3XwiR_wVO... to T2xc0OuiK... (flutter/engine#20155) * e23e477 Lint fixes for fml, tools subdirs (flutter/engine#19990) * f620eac Roll Dart SDK from e87cb96bb89c to bd528bfbd69d (8 revisions) (flutter/engine#20158) * e1c9673 Fix targets in build_fuchsia_artifacts (flutter/engine#19794) * c134e16 add information collection for safari bots (flutter/engine#20123) * ee4d50c Revert "Enable lazy-async-stacks by-default in all modes (2) (flutter#19270)" (flutter/engine#20165) * 357b155 Roll Fuchsia Linux SDK from d4pESQYnB... to d_5wDVmBd... (flutter/engine#20161) * a6cd3eb Fix lint errors in lib/ui (flutter/engine#19988) * 280bbfc This makes the lint script use multiprocessing to speed it up. (flutter/engine#19987)

jason-simmons requested a review from dkwingsmt July 22, 2020 23:42

flutter-dashboard bot added the platform-android label Jul 22, 2020

googlebot added the cla: yes label Jul 22, 2020

auto-assign bot requested a review from iskakaushik July 22, 2020 23:45

jason-simmons force-pushed the bug_61558 branch from fab11aa to 10fb18b Compare July 23, 2020 00:00

chinmaygarde approved these changes Jul 27, 2020

View reviewed changes

dkwingsmt approved these changes Jul 27, 2020

View reviewed changes

liyuqian added the perf: memory Performance issues related to memory label Jul 27, 2020

jason-simmons added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 28, 2020

fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 29, 2020

Add missing MouseCursorPlugin destroy call

72e298e

Fixes flutter/flutter#61558

jason-simmons force-pushed the bug_61558 branch from 10fb18b to 72e298e Compare July 29, 2020 22:35

jason-simmons added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 29, 2020

fluttergithubbot merged commit 8464208 into flutter:master Jul 30, 2020

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 84642088637b (18 revisions) flutter/flutter#62538

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

56201c4

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 5498add1982d (19 revisions) flutter/flutter#62543

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

f698cb7

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 9398bc4b1f4c (20 revisions) flutter/flutter#62545

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

4ba42ba

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 406891841fc2 (22 revisions) flutter/flutter#62554

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

eb8a633

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 4c49e0b19663 (23 revisions) flutter/flutter#62561

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

9f455df

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 4a3688e47b98 (24 revisions) flutter/flutter#62563

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

d13f2b5

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 19368efcc371 (28 revisions) flutter/flutter#62566

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

3d3c5a1

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 0fdb141433da (30 revisions) flutter/flutter#62569

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

c9305a7

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 97d6ee26a614 (31 revisions) flutter/flutter#62573

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

3d922cd

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to da3d4958b8e1 (32 revisions) flutter/flutter#62575

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

fad9482

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 27b61e7ac8d6 (35 revisions) flutter/flutter#62581

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

f3ec38c

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 146d5049019a (36 revisions) flutter/flutter#62592

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

d8eb400

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to f2b02d8fd53b (39 revisions) flutter/flutter#62607

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

771aea8

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to 7c5162e0a62c (41 revisions) flutter/flutter#62610

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

d9a66f6

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to e23e4775ae62 (42 revisions) flutter/flutter#62617

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

8184e5d

)

engine-flutter-autoroll mentioned this pull request Jul 30, 2020

Roll Engine from a9910e409c02 to e1c9673bbb63 (44 revisions) flutter/flutter#62624

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

8ea5d1f

)

engine-flutter-autoroll mentioned this pull request Jul 31, 2020

Roll Engine from a9910e409c02 to c134e1658d56 (45 revisions) flutter/flutter#62629

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

7fe867a

)

engine-flutter-autoroll mentioned this pull request Jul 31, 2020

Roll Engine from a9910e409c02 to 280bbfc763cf (49 revisions) flutter/flutter#62647

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2020

8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968

878795d

)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing MouseCursorPlugin destroy call #19968

Add missing MouseCursorPlugin destroy call #19968

jason-simmons commented Jul 22, 2020

flutter-dashboard bot commented Jul 22, 2020

fluttergithubbot commented Jul 29, 2020

Add missing MouseCursorPlugin destroy call #19968

Add missing MouseCursorPlugin destroy call #19968

Conversation

jason-simmons commented Jul 22, 2020

flutter-dashboard bot commented Jul 22, 2020

fluttergithubbot commented Jul 29, 2020