WIP: API to track damage rectangles #21267
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces #21126
This PR adds api to track damage rectangles during rendering. Usage is relatively simple, it introduces the following structure in
compositor_context.h
This can be provided as argument to
CompositorContext::ScopedFrame::Raster
. The caller is responsible for providingprevious_frame_description
, which was obtained during previous rasterization to current framebuffer, as well as storing incomingframe_description
.Related Issues
flutter/flutter#33939
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.Breaking Change
This shouldn't be breaking change, if
frame_damage
is not provided (default).However it does prevent rendering of picture, physical shape and texture layers that are outside of cull rect.
Did any tests fail when you ran them? Please read [handling breaking changes].