Allow dumping trace information during GN calls. #25739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--trace-gn` to `./flutter/tools/gn` should now dump a `gn_trace.json` in the build directory. This is not on by default because capturing and generating the traces seems to take about a second itself. So it is opt-in. Related to flutter/flutter#81074
chinmaygarde
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 24, 2021
GuoXi
pushed a commit
to GuoXi/engine
that referenced
this pull request
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--trace-gnto./flutter/tools/gnshould now dump agn_trace.jsonin thebuild directory. This is not on by default because capturing and generating the
traces seems to take about a second itself. So it is opt-in.
Related to flutter/flutter#81074