-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate flutter_runner to Scenic.CreateSessionT. #26536
Conversation
This will move us closer to a state where we don't need the `SessionListener` anymore and the ways of receiving input events are decoupled from the use of `Session` vs `Flatland`. See fxbug.dev/77480.
@arbreng this can't be all of the work we need for https://fxbug.dev/77480, right? |
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This will move us closer to a state where we don't need the
SessionListener
anymore and the ways of receiving input events are decoupled from the use ofSession
vsFlatland
.See https://fxbug.dev/77480.