Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Issues/80711 reland (#26813)" #26859

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Revert "Issues/80711 reland (#26813)" #26859

merged 1 commit into from
Jun 21, 2021

Conversation

chunhtai
Copy link
Contributor

This reverts commit 53e4dcf.

Internal test failure

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jun 21, 2021
@chunhtai chunhtai requested a review from renyou June 21, 2021 17:19
@chunhtai chunhtai merged commit 302fbf4 into flutter:master Jun 21, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 21, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 21, 2021
@engine-flutter-autoroll
302fbf4 Revert "Issues/80711 reland (flutter#26813)" (flutter/engine#…
89be7d1 
…26859)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 22, 2021
@engine-flutter-autoroll
302fbf4 Revert "Issues/80711 reland (flutter#26813)" (flutter/engine#…
3382cc9 
…26859)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 22, 2021
@engine-flutter-autoroll
302fbf4 Revert "Issues/80711 reland (flutter#26813)" (flutter/engine#…
3637afd 
…26859)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 22, 2021
@engine-flutter-autoroll
302fbf4 Revert "Issues/80711 reland (flutter#26813)" (flutter/engine#…
b79637a 
…26859)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 22, 2021
@engine-flutter-autoroll
302fbf4 Revert "Issues/80711 reland (flutter#26813)" (flutter/engine#…
8108882 
…26859)
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
@chunhtai @moffatman
Revert "Issues/80711 reland (flutter#26813)" (flutter#26859)
3b913d6 
This reverts commit 53e4dcf.
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@chunhtai
Revert "Issues/80711 reland (flutter#26813)" (flutter#26859)
a230f43 
This reverts commit 53e4dcf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renyou renyou renyou approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chunhtai @renyou