Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll CanvasKit to 0.28.0 #26944

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Roll CanvasKit to 0.28.0 #26944

merged 2 commits into from
Jun 24, 2021

Conversation

harryterkelsen
Copy link
Contributor

Rolls CanvasKit to 0.28.0

Fixes flutter/flutter#80140

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Jun 24, 2021
@google-cla google-cla bot added the cla: yes label Jun 24, 2021
yjbanov
yjbanov approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harryterkelsen harryterkelsen merged commit 739b259 into flutter:master Jun 24, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2021
@engine-flutter-autoroll
739b259 Roll CanvasKit to 0.28.0 (flutter/engine#26944)
ab3f438
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
@moffatman
Roll CanvasKit to 0.28.0 (flutter#26944)
48e6e38 
* Roll CanvasKit to 0.28.0

* Skip test on Safari
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
Roll CanvasKit to 0.28.0 (flutter#26944)
c413638 
* Roll CanvasKit to 0.28.0

* Skip test on Safari
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
cla: yes platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web: Random crash RuntimeError: memory access out of bounds upon running app for first time.
2 participants
@harryterkelsen @yjbanov