Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the Android API JAR ahead of the third-party dependencies in the Javadoc classpath #27125

Merged
merged 1 commit into from Jul 2, 2021
Merged

Move the Android API JAR ahead of the third-party dependencies in the Javadoc classpath #27125

merged 1 commit into from Jul 2, 2021

Conversation

jason-simmons
Copy link
Member

No description provided.

@google-cla google-cla bot added the cla: yes label Jul 1, 2021
dnfield
dnfield approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What problem(s) was this causing? LGTM anyway

@jason-simmons
Copy link
Member Author

I was getting errors when running the gen_javadoc script on my gLinux box due to something in android_embedding_dependencies overriding the more recent version of the Android APIs in android-30/android.jar

@dnfield
Copy link
Contributor

dnfield commented Jul 1, 2021

Ahh ok, cool. I think this might have been an issue for @Piinks recently too. /cc @blasten FYI

@jason-simmons
Copy link
Member Author

In particular, android_embedding_dependencies on my setup contains symlinks to two Robolectric JARs, each of which contains an android.os.Build class that will conflict with android.jar

@jason-simmons jason-simmons added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 1, 2021
@fluttergithubbot fluttergithubbot merged commit e8785b6 into flutter:master Jul 2, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2021
@engine-flutter-autoroll
e8785b6 Move the Android API JAR ahead of the third-party dependencie…
ae7922f 
…s in the Javadoc classpath (flutter/engine#27125)
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
@jason-simmons @moffatman
Move the Android API JAR ahead of the third-party dependencies in the…
f0ea3e0 
… Javadoc classpath (flutter#27125)
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@jason-simmons
Move the Android API JAR ahead of the third-party dependencies in the…
3ece048 
… Javadoc classpath (flutter#27125)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blasten blasten blasten approved these changes

@dnfield dnfield dnfield approved these changes

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
4 participants
@jason-simmons @dnfield @blasten @fluttergithubbot