Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[canvaskit] Optimize CanvasKit platform views in special cases #28087

Merged
merged 19 commits into from
Sep 8, 2021
Merged

[canvaskit] Optimize CanvasKit platform views in special cases #28087

merged 19 commits into from
Sep 8, 2021

Conversation

harryterkelsen
Copy link
Contributor

Diff the old and new platform view list and attempt to elminate most DOM manipulation in the common case.

Addresses flutter/flutter#86868 for CanvasKit

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Aug 14, 2021
@google-cla google-cla bot added the cla: yes label Aug 14, 2021
yjbanov
yjbanov reviewed Sep 1, 2021
View reviewed changes
lib/web_ui/lib/src/engine/canvaskit/surface_factory.dart Outdated Show resolved Hide resolved
lib/web_ui/lib/src/engine/canvaskit/embedded_views.dart
/// on which direction the list is scrolling. One or more views will be added
/// to the beginning of the list, and one or more views will be removed from
/// the end of the list, with the order of the unchanged middle views
/// remaining the same.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout _insertChildDomNodes. With the same amount of code (reusing longestIncreasingSubsequence) we should be able to find the optimal solution for all situations, including the scroll case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a TODO. That refactor would also necessitate copying more code, for instance to generate the index maps.

lib/web_ui/lib/src/engine/canvaskit/embedded_views.dart Show resolved Hide resolved
yjbanov
yjbanov approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harryterkelsen harryterkelsen mentioned this pull request Sep 7, 2021
Closed
@harryterkelsen harryterkelsen mentioned this pull request Sep 7, 2021
Closed
@harryterkelsen harryterkelsen merged commit b073e36 into flutter:master Sep 8, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
bfd6f76 
flutter/engine#28087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
d803add 
flutter/engine#28087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
da7f868 
flutter/engine#28087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
ac32b49 
flutter/engine#28087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
c055260 
flutter/engine#28087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
64d6e3f 
flutter/engine#28087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
9aeb888 
flutter/engine#28087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
ae19a8c 
flutter/engine#28087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
3196a1d 
flutter/engine#28087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
d0935dd 
flutter/engine#28087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
54e52e1 
flutter/engine#28087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
7ab9170 
flutter/engine#28087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
e01a609 
flutter/engine#28087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
d1461d0 
flutter/engine#28087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 10, 2021
@engine-flutter-autoroll
b073e36 [canvaskit] Optimize CanvasKit platform views in special cases (
8350bfe 
flutter/engine#28087)
@tvolkert tvolkert mentioned this pull request Sep 10, 2021
Closed
@yjbanov yjbanov mentioned this pull request Sep 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
cla: yes platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harryterkelsen @yjbanov