Prepare scripts for the master to main migration. #29371
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
platform-web
| @@ -234,7 +234,7 @@ class GoldensRepoFetcher { | |||
| } | |||
|
|
|||
| await _runGit( | |||
| <String>['fetch', 'origin', 'master'], | |||
| <String>['fetch', 'origin', 'main'], | |||
There was a problem hiding this comment.
Is _webUiGoldensRepositoryDirectory a flutter/engine checkout? If not, does the web UI goldens repository already have a main branch?
There was a problem hiding this comment.
Looks like it doesn't have a main branch: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8832168966148676849/+/u/felt_test:_firefox-unit-linux/stdout?format=raw
There was a problem hiding this comment.
Good, point. I just added a main branch mirror to the goldens repo. I'll create an independent PR for this file.
There was a problem hiding this comment.
Change landed as #29389
It changes master branch with main to prepare for the migration. This change will be landed in synchronization with changes to modify the engine default branch to main. Bug: flutter/flutter#90476
It changes master branch with main to prepare for the migration.
This change will be landed in synchronization with changes to modify
the engine default branch to main.
Bug: flutter/flutter#90476
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.