Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][iOS] infer dynamic refresh rate via heuristics. #29692

Closed
wants to merge 9 commits into from

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Nov 11, 2021

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz added the Work in progress (WIP) Not ready (yet) for review! label Nov 11, 2021
@google-cla google-cla bot added the cla: yes label Nov 11, 2021
@CaseyHillers CaseyHillers changed the base branch from master to main November 15, 2021 18:11
@iskakaushik iskakaushik self-requested a review November 16, 2021 16:38
@iskakaushik
Copy link
Contributor

cc: @iskakaushik

@cyanglaz cyanglaz changed the base branch from master to main November 18, 2021 17:27
@cyanglaz cyanglaz marked this pull request as ready for review November 29, 2021 21:18
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@cyanglaz cyanglaz marked this pull request as draft November 29, 2021 21:19
@cyanglaz cyanglaz closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants