Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support iOS Premotion refresh rate #30900

Closed
wants to merge 8 commits into from
Closed

[WIP] Support iOS Premotion refresh rate #30900

wants to merge 8 commits into from

Conversation

luckysmg
Copy link
Contributor

@luckysmg luckysmg commented Jan 16, 2022

This PR lets engine can change the screen's refresh rate (only iOS now).The framework will call window.updateFrameRate(frameRate) to let engine to update frame rate.

This solution is functionally feasible, but needs further discussion with the flutter team

The flutter framework PR:flutter/flutter#96710

List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#90675

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@luckysmg luckysmg marked this pull request as draft January 16, 2022 02:51
@luckysmg luckysmg changed the title Support iOS Premotion refresh rates Support iOS Premotion refresh rate Jan 16, 2022
@luckysmg luckysmg changed the title Support iOS Premotion refresh rate [WIP] Support iOS Premotion refresh rate Jan 23, 2022
@luckysmg luckysmg closed this Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant