Reland "Hardware Keyboard: Android" #33567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
embedder
dkwingsmt
force-pushed
the
reland-android-key-embedder-responder
branch
from
9422ccf
to
e9c7b59
Compare
dkwingsmt
force-pushed
the
reland-android-key-embedder-responder
branch
from
2f55a1d
to
c729465
Compare
dkwingsmt
added a commit
that referenced
this pull request
May 24, 2022
This reverts commit ea9c2ec.
dkwingsmt
added a commit
that referenced
this pull request
May 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 24, 2022
8 tasks
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #33113, which was reverted due to possible internal breakages.
Changes based on the original PR: (See latest commits)
This PR implements the embedder keyboard responder of the Android embedding, the backend of
HardwareKeyboardon Android. This is the last platform to support it.The behaviors are tested on a ChromeOS over ARC++. There are some weird behaviors, mostly for
metaState, which I'm not sure is the fault of ARC++ or Android. I don't have an Android device with keyboard to test for now. Therefore the synchronization logic is implemented in a loose way.There are a few known issues:
The framework PR flutter/flutter#104032 generates the necessary codes for this PR.
Related Issues
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.