Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new pointer signal for cancelling scroll inertia #34402

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Add new pointer signal for cancelling scroll inertia #34402

merged 1 commit into from
Jul 8, 2022

Conversation

moffatman
Copy link
Contributor

@moffatman moffatman commented Jun 30, 2022 •
edited
Loading

It's expected behaviour on some platforms that scroll inertia/momentum animations will stop when a finger is rested on the trackpad. This PR introduces a new kind of pointer signal event which will be used to transmit that message.

Blocked on: flutter/flutter#106906

Framework PR: flutter/flutter#106891

Engine PRs for iPadOS, macOS, and Win32 to follow

Part of flutter/flutter#106979

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the embedder Related to the embedder API label Jun 30, 2022
This was referenced Jun 30, 2022
Merged
Merged
@HansMuller HansMuller requested a review from dkwingsmt July 1, 2022 21:43
dkwingsmt
dkwingsmt approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

goderbauer
goderbauer approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moffatman moffatman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 8, 2022
@auto-submit auto-submit bot merged commit f34a228 into flutter:main Jul 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 8, 2022
@engine-flutter-autoroll
f34a228 Add new pointer signal for cancelling scroll inertia (flutter…
a9c488a 
…/engine#34402)
@moffatman moffatman mentioned this pull request Jul 8, 2022
Closed
8 tasks
dkwingsmt added a commit that referenced this pull request Jul 8, 2022
@dkwingsmt
Revert "Add new pointer signal for cancelling scroll inertia (#34402)"
7e97b33 
This reverts commit f34a228.
@dkwingsmt dkwingsmt mentioned this pull request Jul 8, 2022
Merged
dkwingsmt added a commit that referenced this pull request Jul 8, 2022
@dkwingsmt
Revert "Add new pointer signal for cancelling scroll inertia (#34402)" (
088f925 
#34535)

This reverts commit f34a228.
moffatman added a commit to moffatman/engine that referenced this pull request Jul 8, 2022
@moffatman
Add new pointer signal for cancelling scroll inertia (flutter#34402)
540c66e
@moffatman moffatman mentioned this pull request Jul 8, 2022
Merged
8 tasks
moffatman added a commit to moffatman/engine that referenced this pull request Jul 13, 2022
@moffatman
Add new pointer signal for cancelling scroll inertia (flutter#34402)
42810fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App embedder Related to the embedder API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moffatman @goderbauer @dkwingsmt