Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll Skia from e91a18df0c38 to 545e45ab4d5d (3 revisions) #35790

Conversation

skia-flutter-autoroll
Copy link
Contributor

https://skia.googlesource.com/skia.git/+log/e91a18df0c38..545e45ab4d5d

2022-08-29 brianosman@google.com Optimize cond_to_mask in non-scalar configurations
2022-08-29 bsalomon@google.com [ganesh] Add staging buffer manager to GL for SkMesh buffer updates
2022-08-29 egdaniel@google.com [Graphite] Share VkInterface between Ganesh and Graphite.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kjlubick@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/e91a18df0c38..545e45ab4d5d

2022-08-29 brianosman@google.com Optimize cond_to_mask in non-scalar configurations
2022-08-29 bsalomon@google.com [ganesh] Add staging buffer manager to GL for SkMesh buffer updates
2022-08-29 egdaniel@google.com [Graphite] Share VkInterface between Ganesh and Graphite.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kjlubick@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll skia-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2022
@skia-flutter-autoroll skia-flutter-autoroll force-pushed the skia-flutter-autoroll-5033f2c6-7002-4d3d-814b-376bb2b6fb00-1661809776 branch from 981f089 to 8ab2f60 Compare August 29, 2022 21:49
@zanderso
Copy link
Member

@keyonghan This skia -> engine roll looks like it is missing lgtm from the bot.

@zanderso
Copy link
Member

@yusuf-goog infra oncall.

@keyonghan
Copy link
Contributor

Checked we have a manual version push at 2:46pm yesterday, around the time this PR created, which I believe cause this PR not picked up by the backend auto-submit service.
To avoid this issue happening again, we should enforce the cloud build and disallow random manual push. Security team is working on this. /cc @godofredoc @ricardoamador

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso
Copy link
Member

@keyonghan It looks like the autosubmit bot is also ignoring this PR. I am going to land it manually.

@zanderso zanderso merged commit 0ef08a8 into flutter:main Aug 30, 2022
@skia-flutter-autoroll skia-flutter-autoroll deleted the skia-flutter-autoroll-5033f2c6-7002-4d3d-814b-376bb2b6fb00-1661809776 branch September 5, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants