Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Linux Web Engine Bringup. #37658

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Mark Linux Web Engine Bringup. #37658

merged 1 commit into from
Nov 16, 2022

Conversation

godofredoc
Copy link
Contributor

This is to open the tree while downloading firefox is fixed.

Bug: flutter/flutter#115404

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Mark Linux Web Engine Bringup.
ad1be08 
This is to open the tree while downloading firefox is fixed.

Bug: flutter/flutter#115404
harryterkelsen
harryterkelsen approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App and removed warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App labels Nov 16, 2022
@godofredoc
Copy link
Contributor Author

Landing this PR as firefox installation keeps failing

@auto-submit auto-submit bot merged commit c225207 into flutter:main Nov 16, 2022
@godofredoc godofredoc deleted the mark_web_engine_bringup branch November 16, 2022 03:21
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 16, 2022
@engine-flutter-autoroll
c22520758 Mark Linux Web Engine Bringup. (flutter/engine#37658)
626d3db
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 16, 2022
@engine-flutter-autoroll
Roll Flutter Engine from c062f7ea7195 to 03e9a97f8abe (3 revisions) (#…
27ff6a5 
…115410)

* fa0f252a2 Roll Dart SDK from 8132f04a0b86 to 7163c9627d98 (1 revision) (flutter/engine#37657)

* c22520758 Mark Linux Web Engine Bringup. (flutter/engine#37658)

* 03e9a97f8 Adding sdk_version to mac builds for dart-internal. (flutter/engine#37651)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
@godofredoc @schwa423
Mark Linux Web Engine Bringup. (flutter#37658)
4036948 
This is to open the tree while downloading firefox is fixed.

Bug: flutter/flutter#115404
@keyonghan keyonghan mentioned this pull request Nov 18, 2022
Merged
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
Roll Flutter Engine from c062f7ea7195 to 03e9a97f8abe (3 revisions) (f…
1717b48 
…lutter#115410)

* fa0f252a2 Roll Dart SDK from 8132f04a0b86 to 7163c9627d98 (1 revision) (flutter/engine#37657)

* c22520758 Mark Linux Web Engine Bringup. (flutter/engine#37658)

* 03e9a97f8 Adding sdk_version to mac builds for dart-internal. (flutter/engine#37651)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from c062f7ea7195 to 03e9a97f8abe (3 revisions) (f…
9399b33 
…lutter#115410)

* fa0f252a2 Roll Dart SDK from 8132f04a0b86 to 7163c9627d98 (1 revision) (flutter/engine#37657)

* c22520758 Mark Linux Web Engine Bringup. (flutter/engine#37658)

* 03e9a97f8 Adding sdk_version to mac builds for dart-internal. (flutter/engine#37651)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryterkelsen harryterkelsen harryterkelsen approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godofredoc @harryterkelsen