Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on objc-* clang-tidy checks #37813

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 21, 2022

Turn on checks:

Keep objc-nsinvocation-argument-lifetime check off since OCMock macros are generating failures:

❌ Failures for clang-tidy on /Volumes/Work/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterChannelKeyResponderTest.mm:
/Volumes/Work/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterChannelKeyResponderTest.mm:48:33: error: NSInvocation '-getArgument:atIndex:' should only pass pointers to objects with ownership __unsafe_unretained [objc-nsinvocation-argument-lifetime,-warnings-as-errors]
        [invocation getArgument:&message atIndex:2];
                                ^
../../third_party/ocmock/Source/OCMock/OCMStubRecorder.h:55:30: note: expanded from macro 'andDo'
#define andDo(aBlock) _andDo(aBlock)

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8796856828802754401/+/u/test:_lint_host_debug/stdout

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman marked this pull request as ready for review November 22, 2022 01:08
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 22, 2022
@auto-submit auto-submit bot merged commit 4bf16c3 into flutter:main Nov 22, 2022
@jmagman jmagman deleted the objc-clang-tidy branch November 22, 2022 23:10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 23, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 23, 2022
…115888)

* 3c2784757 Turn on darwin-* clang-tidy checks (flutter/engine#37814)

* 4bf16c369 Turn on objc-* clang-tidy checks (flutter/engine#37813)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#115888)

* 3c2784757 Turn on darwin-* clang-tidy checks (flutter/engine#37814)

* 4bf16c369 Turn on objc-* clang-tidy checks (flutter/engine#37813)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#115888)

* 3c2784757 Turn on darwin-* clang-tidy checks (flutter/engine#37814)

* 4bf16c369 Turn on objc-* clang-tidy checks (flutter/engine#37813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios platform-macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants