Create a unique command pool per render pass #37965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the command pool is not accessed from multiple threads at the same time. This fixes the validation errors: ``` Check failed: false. Error[337425955][UNASSIGNED-Threading-MultipleThreads] : Validation Error: [ UNASSIGNED-Threading-MultipleThreads ] Object 0: handle = 0x59ffe0000000003d, type = VK_OBJECT_TYPE_COMMAND_POOL; | MessageID = 0x141cb623 | THREADING ERROR : vkFreeCommandBuffers(): object of type VkCommandPool is simultaneously used in thread 471586061488 and thread 471275924656' ```
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
Nov 29, 2022
iskakaushik
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 29, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 29, 2022
…116217) * dbb697c9a Create a unique command pool per render pass (flutter/engine#37965) * d85707af0 Roll Skia from a82a7b6da0a0 to 829527b29b32 (4 revisions) (flutter/engine#37966)
mit-mit
pushed a commit
to mit-mit/flutter
that referenced
this pull request
Dec 6, 2022
…lutter#116217) * dbb697c9a Create a unique command pool per render pass (flutter/engine#37965) * d85707af0 Roll Skia from a82a7b6da0a0 to 829527b29b32 (4 revisions) (flutter/engine#37966)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#116217) * dbb697c9a Create a unique command pool per render pass (flutter/engine#37965) * d85707af0 Roll Skia from a82a7b6da0a0 to 829527b29b32 (4 revisions) (flutter/engine#37966)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#116217) * dbb697c9a Create a unique command pool per render pass (flutter/engine#37965) * d85707af0 Roll Skia from a82a7b6da0a0 to 829527b29b32 (4 revisions) (flutter/engine#37966)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the command pool is not accessed from multiple threads at the same time. This fixes the validation errors: