Shader analysis with malioc #39005
Merged
Shader analysis with malioc #39005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
Jan 19, 2023
zanderso
commented
Jan 19, 2023
| } | ||
|
|
||
| template("malioc_analyze_shaders") { | ||
| # TODO(zra): Check that gles_language_version is in the supported set. For now |
There was a problem hiding this comment.
@jonahwilliams ssbos requires a higher language version, so when any language version is set, analysis is skipped. This TODO is for tightening this logic to match what the analyzer supports.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 19, 2023
…118839) * f2536ce8d Shader analysis with malioc (flutter/engine#39005) * dd8c259bb [Impeller] Account for the transform in DLVerticesGeometry coverage (flutter/engine#38998) * 26b6609c6 Remove unused variables and import (flutter/engine#38971)
ricardoamador
pushed a commit
to ricardoamador/engine
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to the GN build to analyze shaders and output the analysis results in the build output directory unconditionally when the build is configured with the path to
maliocusing the--malioc-pathflag passed to thegnscript.maliocis quite fast, so this does not affect build times.This PR also adds a script
impeller/tools/malioc_diff.pythat detects before/after changes in the results ofmalioc's analysis, or generate a analysis results golden file. In a subsequent PR, the plan is to check in such a golden file, and then compare shader analysis results on PRs/commits against the golden file in CI.