-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shader analysis with malioc #39005
Shader analysis with malioc #39005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does this handle the SSBO shaders?
LGTM
} | ||
|
||
template("malioc_analyze_shaders") { | ||
# TODO(zra): Check that gles_language_version is in the supported set. For now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonahwilliams ssbos requires a higher language version, so when any language version is set, analysis is skipped. This TODO is for tightening this logic to match what the analyzer supports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense!
…118839) * f2536ce8d Shader analysis with malioc (flutter/engine#39005) * dd8c259bb [Impeller] Account for the transform in DLVerticesGeometry coverage (flutter/engine#38998) * 26b6609c6 Remove unused variables and import (flutter/engine#38971)
This PR adds logic to the GN build to analyze shaders and output the analysis results in the build output directory unconditionally when the build is configured with the path to
malioc
using the--malioc-path
flag passed to thegn
script.malioc
is quite fast, so this does not affect build times.This PR also adds a script
impeller/tools/malioc_diff.py
that detects before/after changes in the results ofmalioc
's analysis, or generate a analysis results golden file. In a subsequent PR, the plan is to check in such a golden file, and then compare shader analysis results on PRs/commits against the golden file in CI.