New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Impeller] Migrate gaussian blur to half precision. #40800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I've got the Friday afternoon brain fog. Could you spell out the conclusion from the before/after data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm w/ above question.
I guess the effects of this will show up in the new blur benchmark?
I would not expect to see a significant difference except in power consumption. This change is the same as previous one, but it retains high precision in the input texture coordinates. |
…sions) (#123924) Manual roll requested by zra@google.com flutter/engine@b2855e0...a48eedb 2023-04-01 zanderso@users.noreply.github.com Revert "[web] Move text editing nodes outside of shadowDOM" (flutter/engine#40847) 2023-04-01 skia-flutter-autoroll@skia.org Roll Skia from 4d1e9cabf0c8 to 9973ef180f1f (2 revisions) (flutter/engine#40843) 2023-04-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 6ac8d3ad105f to 7e36e11608f3 (6 revisions) (flutter/engine#40842) 2023-04-01 jonahwilliams@google.com [Impeller] take advantage of native decal sampling, blend cleanups (flutter/engine#40839) 2023-04-01 yjbanov@google.com Revert "[web] use callConstructor for FinalizationRegistry due to bug… (flutter/engine#40841) 2023-04-01 zanderso@users.noreply.github.com Revert "Add ui_web to embedder.yaml so that the analyzer knows about it." (flutter/engine#40840) 2023-04-01 jonahwilliams@google.com [Impeller] Migrate gaussian blur to half precision. (flutter/engine#40800) 2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 33f80c07a09c to 4d1e9cabf0c8 (3 revisions) (flutter/engine#40836) 2023-03-31 110993981+htoor3@users.noreply.github.com [web] Move text editing nodes outside of shadowDOM (flutter/engine#39688) 2023-03-31 mdebbar@google.com [web] Fix canvasKitVariant test (flutter/engine#40833) 2023-03-31 yjbanov@google.com [web] use callConstructor for FinalizationRegistry due to bug in dart2js (flutter/engine#40798) 2023-03-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kiAbXJ_MIn6CAC9-C... to f16HBH4MJdaKy7Hlf... (flutter/engine#40831) 2023-03-31 godofredoc@google.com Remove ios-release-nobitcode from engine v2 builders. (flutter/engine#40830) 2023-03-31 jacksongardner@google.com Add ui_web to embedder.yaml so that the analyzer knows about it. (flutter/engine#40827) 2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 2b86c6d364d0 to 33f80c07a09c (1 revision) (flutter/engine#40826) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from kiAbXJ_MIn6C to f16HBH4MJdaK If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…sions) (flutter#123924) Manual roll requested by zra@google.com flutter/engine@b2855e0...a48eedb 2023-04-01 zanderso@users.noreply.github.com Revert "[web] Move text editing nodes outside of shadowDOM" (flutter/engine#40847) 2023-04-01 skia-flutter-autoroll@skia.org Roll Skia from 4d1e9cabf0c8 to 9973ef180f1f (2 revisions) (flutter/engine#40843) 2023-04-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 6ac8d3ad105f to 7e36e11608f3 (6 revisions) (flutter/engine#40842) 2023-04-01 jonahwilliams@google.com [Impeller] take advantage of native decal sampling, blend cleanups (flutter/engine#40839) 2023-04-01 yjbanov@google.com Revert "[web] use callConstructor for FinalizationRegistry due to bug… (flutter/engine#40841) 2023-04-01 zanderso@users.noreply.github.com Revert "Add ui_web to embedder.yaml so that the analyzer knows about it." (flutter/engine#40840) 2023-04-01 jonahwilliams@google.com [Impeller] Migrate gaussian blur to half precision. (flutter/engine#40800) 2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 33f80c07a09c to 4d1e9cabf0c8 (3 revisions) (flutter/engine#40836) 2023-03-31 110993981+htoor3@users.noreply.github.com [web] Move text editing nodes outside of shadowDOM (flutter/engine#39688) 2023-03-31 mdebbar@google.com [web] Fix canvasKitVariant test (flutter/engine#40833) 2023-03-31 yjbanov@google.com [web] use callConstructor for FinalizationRegistry due to bug in dart2js (flutter/engine#40798) 2023-03-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kiAbXJ_MIn6CAC9-C... to f16HBH4MJdaKy7Hlf... (flutter/engine#40831) 2023-03-31 godofredoc@google.com Remove ios-release-nobitcode from engine v2 builders. (flutter/engine#40830) 2023-03-31 jacksongardner@google.com Add ui_web to embedder.yaml so that the analyzer knows about it. (flutter/engine#40827) 2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 2b86c6d364d0 to 33f80c07a09c (1 revision) (flutter/engine#40826) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from kiAbXJ_MIn6C to f16HBH4MJdaK If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
From bisecting through the shader performance, i've determined something odd which is that both the vector operations in IPHalfSampleDecal and the conversion of the input texture coordinates to half precision led to the regressed performance. No other changes cause a performance regression, at least locally - and should be safe to reland so that we can get the benefits of reduced CPU usage. I will update this with local benchmark numbers shortly.
BEFORE
AFTER