[web] use callConstructor for FinalizationRegistry due to bug in dart2js #40798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
yjbanov
force-pushed
the
fix-finalization-registry
branch
from
dee3664
to
8ba31d0
Compare
yjbanov
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 40798, due to - The status or check suite Linux Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
yjbanov
force-pushed
the
fix-finalization-registry
branch
from
8ba31d0
to
9cb7b78
Compare
yjbanov
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2023
yjbanov
added a commit
to yjbanov/engine
that referenced
this pull request
Apr 1, 2023
… in dart2js (flutter#40798)" This reverts commit d5a0b29.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 1, 2023
…sions) (#123924) Manual roll requested by zra@google.com flutter/engine@b2855e0...a48eedb 2023-04-01 zanderso@users.noreply.github.com Revert "[web] Move text editing nodes outside of shadowDOM" (flutter/engine#40847) 2023-04-01 skia-flutter-autoroll@skia.org Roll Skia from 4d1e9cabf0c8 to 9973ef180f1f (2 revisions) (flutter/engine#40843) 2023-04-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 6ac8d3ad105f to 7e36e11608f3 (6 revisions) (flutter/engine#40842) 2023-04-01 jonahwilliams@google.com [Impeller] take advantage of native decal sampling, blend cleanups (flutter/engine#40839) 2023-04-01 yjbanov@google.com Revert "[web] use callConstructor for FinalizationRegistry due to bug… (flutter/engine#40841) 2023-04-01 zanderso@users.noreply.github.com Revert "Add ui_web to embedder.yaml so that the analyzer knows about it." (flutter/engine#40840) 2023-04-01 jonahwilliams@google.com [Impeller] Migrate gaussian blur to half precision. (flutter/engine#40800) 2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 33f80c07a09c to 4d1e9cabf0c8 (3 revisions) (flutter/engine#40836) 2023-03-31 110993981+htoor3@users.noreply.github.com [web] Move text editing nodes outside of shadowDOM (flutter/engine#39688) 2023-03-31 mdebbar@google.com [web] Fix canvasKitVariant test (flutter/engine#40833) 2023-03-31 yjbanov@google.com [web] use callConstructor for FinalizationRegistry due to bug in dart2js (flutter/engine#40798) 2023-03-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kiAbXJ_MIn6CAC9-C... to f16HBH4MJdaKy7Hlf... (flutter/engine#40831) 2023-03-31 godofredoc@google.com Remove ios-release-nobitcode from engine v2 builders. (flutter/engine#40830) 2023-03-31 jacksongardner@google.com Add ui_web to embedder.yaml so that the analyzer knows about it. (flutter/engine#40827) 2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 2b86c6d364d0 to 33f80c07a09c (1 revision) (flutter/engine#40826) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from kiAbXJ_MIn6C to f16HBH4MJdaK If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…sions) (flutter#123924) Manual roll requested by zra@google.com flutter/engine@b2855e0...a48eedb 2023-04-01 zanderso@users.noreply.github.com Revert "[web] Move text editing nodes outside of shadowDOM" (flutter/engine#40847) 2023-04-01 skia-flutter-autoroll@skia.org Roll Skia from 4d1e9cabf0c8 to 9973ef180f1f (2 revisions) (flutter/engine#40843) 2023-04-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 6ac8d3ad105f to 7e36e11608f3 (6 revisions) (flutter/engine#40842) 2023-04-01 jonahwilliams@google.com [Impeller] take advantage of native decal sampling, blend cleanups (flutter/engine#40839) 2023-04-01 yjbanov@google.com Revert "[web] use callConstructor for FinalizationRegistry due to bug… (flutter/engine#40841) 2023-04-01 zanderso@users.noreply.github.com Revert "Add ui_web to embedder.yaml so that the analyzer knows about it." (flutter/engine#40840) 2023-04-01 jonahwilliams@google.com [Impeller] Migrate gaussian blur to half precision. (flutter/engine#40800) 2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 33f80c07a09c to 4d1e9cabf0c8 (3 revisions) (flutter/engine#40836) 2023-03-31 110993981+htoor3@users.noreply.github.com [web] Move text editing nodes outside of shadowDOM (flutter/engine#39688) 2023-03-31 mdebbar@google.com [web] Fix canvasKitVariant test (flutter/engine#40833) 2023-03-31 yjbanov@google.com [web] use callConstructor for FinalizationRegistry due to bug in dart2js (flutter/engine#40798) 2023-03-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kiAbXJ_MIn6CAC9-C... to f16HBH4MJdaKy7Hlf... (flutter/engine#40831) 2023-03-31 godofredoc@google.com Remove ios-release-nobitcode from engine v2 builders. (flutter/engine#40830) 2023-03-31 jacksongardner@google.com Add ui_web to embedder.yaml so that the analyzer knows about it. (flutter/engine#40827) 2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 2b86c6d364d0 to 33f80c07a09c (1 revision) (flutter/engine#40826) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from kiAbXJ_MIn6C to f16HBH4MJdaK If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
js_util.callConstructorto initializeFinalizationRegistryto make it compatible withdart2js.Fixes b/276167870