Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] take advantage of native decal sampling, blend cleanups #40839

Merged
merged 2 commits into from
Apr 1, 2023
Merged

[Impeller] take advantage of native decal sampling, blend cleanups #40839

merged 2 commits into from
Apr 1, 2023

Conversation

jonahwilliams
Copy link
Member

  • In advanced blend shaders, use native decal sampling where available.
  • In framebuffer blend shaders always use native decal sampling.
  • Adjust blend.frag to do texture flip computation in vertex shader like other samplers, remove tessellation usage in favor of Rect geometry.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

zanderso
zanderso approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2023
@auto-submit auto-submit bot merged commit b449bab into flutter:main Apr 1, 2023
@jonahwilliams jonahwilliams deleted the decal_blend branch April 1, 2023 02:11
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
b449bab3b [Impeller] take advantage of native decal sampling, blend c…
06cbd00 
…leanups (flutter/engine#40839)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
b449bab3b [Impeller] take advantage of native decal sampling, blend c…
5321666 
…leanups (flutter/engine#40839)
zanderso pushed a commit to flutter/flutter that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
Manual roll Flutter Engine from b2855e074deb to a48eedbda125 (15 revi…
7725f59 
…sions) (#123924)

Manual roll requested by zra@google.com

flutter/engine@b2855e0...a48eedb

2023-04-01 zanderso@users.noreply.github.com Revert "[web] Move text
editing nodes outside of shadowDOM" (flutter/engine#40847)
2023-04-01 skia-flutter-autoroll@skia.org Roll Skia from 4d1e9cabf0c8 to
9973ef180f1f (2 revisions) (flutter/engine#40843)
2023-04-01 skia-flutter-autoroll@skia.org Roll Dart SDK from
6ac8d3ad105f to 7e36e11608f3 (6 revisions) (flutter/engine#40842)
2023-04-01 jonahwilliams@google.com [Impeller] take advantage of native
decal sampling, blend cleanups (flutter/engine#40839)
2023-04-01 yjbanov@google.com Revert "[web] use callConstructor for
FinalizationRegistry due to bug… (flutter/engine#40841)
2023-04-01 zanderso@users.noreply.github.com Revert "Add ui_web to
embedder.yaml so that the analyzer knows about it."
(flutter/engine#40840)
2023-04-01 jonahwilliams@google.com [Impeller] Migrate gaussian blur to
half precision. (flutter/engine#40800)
2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 33f80c07a09c to
4d1e9cabf0c8 (3 revisions) (flutter/engine#40836)
2023-03-31 110993981+htoor3@users.noreply.github.com [web] Move text
editing nodes outside of shadowDOM (flutter/engine#39688)
2023-03-31 mdebbar@google.com [web] Fix canvasKitVariant test
(flutter/engine#40833)
2023-03-31 yjbanov@google.com [web] use callConstructor for
FinalizationRegistry due to bug in dart2js (flutter/engine#40798)
2023-03-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
kiAbXJ_MIn6CAC9-C... to f16HBH4MJdaKy7Hlf... (flutter/engine#40831)
2023-03-31 godofredoc@google.com Remove ios-release-nobitcode from
engine v2 builders. (flutter/engine#40830)
2023-03-31 jacksongardner@google.com Add ui_web to embedder.yaml so that
the analyzer knows about it. (flutter/engine#40827)
2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 2b86c6d364d0 to
33f80c07a09c (1 revision) (flutter/engine#40826)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from kiAbXJ_MIn6C to f16HBH4MJdaK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@engine-flutter-autoroll @exaby73
Manual roll Flutter Engine from b2855e074deb to a48eedbda125 (15 revi…
294f161 
…sions) (flutter#123924)

Manual roll requested by zra@google.com

flutter/engine@b2855e0...a48eedb

2023-04-01 zanderso@users.noreply.github.com Revert "[web] Move text
editing nodes outside of shadowDOM" (flutter/engine#40847)
2023-04-01 skia-flutter-autoroll@skia.org Roll Skia from 4d1e9cabf0c8 to
9973ef180f1f (2 revisions) (flutter/engine#40843)
2023-04-01 skia-flutter-autoroll@skia.org Roll Dart SDK from
6ac8d3ad105f to 7e36e11608f3 (6 revisions) (flutter/engine#40842)
2023-04-01 jonahwilliams@google.com [Impeller] take advantage of native
decal sampling, blend cleanups (flutter/engine#40839)
2023-04-01 yjbanov@google.com Revert "[web] use callConstructor for
FinalizationRegistry due to bug… (flutter/engine#40841)
2023-04-01 zanderso@users.noreply.github.com Revert "Add ui_web to
embedder.yaml so that the analyzer knows about it."
(flutter/engine#40840)
2023-04-01 jonahwilliams@google.com [Impeller] Migrate gaussian blur to
half precision. (flutter/engine#40800)
2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 33f80c07a09c to
4d1e9cabf0c8 (3 revisions) (flutter/engine#40836)
2023-03-31 110993981+htoor3@users.noreply.github.com [web] Move text
editing nodes outside of shadowDOM (flutter/engine#39688)
2023-03-31 mdebbar@google.com [web] Fix canvasKitVariant test
(flutter/engine#40833)
2023-03-31 yjbanov@google.com [web] use callConstructor for
FinalizationRegistry due to bug in dart2js (flutter/engine#40798)
2023-03-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
kiAbXJ_MIn6CAC9-C... to f16HBH4MJdaKy7Hlf... (flutter/engine#40831)
2023-03-31 godofredoc@google.com Remove ios-release-nobitcode from
engine v2 builders. (flutter/engine#40830)
2023-03-31 jacksongardner@google.com Add ui_web to embedder.yaml so that
the analyzer knows about it. (flutter/engine#40827)
2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 2b86c6d364d0 to
33f80c07a09c (1 revision) (flutter/engine#40826)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from kiAbXJ_MIn6C to f16HBH4MJdaK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests
Projects
None yet
Milestone
No milestone
2 participants
@jonahwilliams @zanderso