Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JSNumber.toDart and Object.toJS #43149

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Commits on Jun 23, 2023

  1. Refactor JSNumber.toDart and Object.toJS

    JSNumber.toDart will now be two functions: toDartDouble and
    toDartInt. Note that some code that looks like `toDart.toInt()`
    was kept as `toDartDouble.toInt()` instead of `toDartInt`, since
    `toDartInt` throws if the value is not an integer.
    
    Object.toJS is now Object.toJSBox. An actual box is introduced on
    all backends now, and is unwrapped in JSBoxedDartObject.toDart.
    There are many usages of toJSAnyShallow that we should modify, but
    that's for a later CL.
    srujzs committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    ca41476 View commit details
    Browse the repository at this point in the history