Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporaribly disable bottom safe area padding on iOS #4322

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Nov 3, 2017

There are two different sets of view insets that applications may want
to track in order to avoid unwanted interaction with system UI:

  1. OS UI that effectively shrinks the Flutter view from a UX point of
    view: e.g., when the keyboard opens, it occludes the bottom of the
    screen and the view should be adjusted such that the bottom, for the
    purposes of scrolling is just above the keyboard.
  2. OS UI that is overlaid over the application, but into which the
    application should draw. e.g., the Home indicator on the iPhone X
    typically appears near the bottom of the screen, overlaid over app
    content. Content should be rendered within this 'safe area' but apps
    should avoid requiring user interaction there. For example, list
    views may want to include some small amount of additional padding to
    ensure the last list item can scroll above this area.

Since Flutter does not currently distinguish between these two cases,
this patch disables the bottom safe area inset until API is added to
support these separately.

There are two different sets of view insets that applications may want
to track in order to avoid unwanted interaction with system UI:

1. OS UI that effectively shrinks the Flutter view from a UX point of
   view: e.g., when the keyboard opens, it occludes the bottom of the
   screen and the view should be adjusted such that the bottom, for the
   purposes of scrolling is just above the keyboard.
2. OS UI that is overlaid over the application, but into which the
   application should draw. e.g., the Home indicator on the iPhone X
   typically appears near the bottom of the screen, overlaid over app
   content. Content should be rendered within this 'safe area' but apps
   should avoid requiring user interaction there. For example, list
   views may want to include some small amount of additional padding to
   ensure the last list item can scroll above this area.

Since Flutter does not currently distinguish between these two cases,
this patch disables the bottom safe area inset until API is added to
support these separately.
@cbracken cbracken merged commit e059cc0 into flutter:master Nov 3, 2017
@cbracken cbracken deleted the no-bottom-safe-area branch November 3, 2017 21:20
@xster
Copy link
Member

xster commented Nov 4, 2017

Since you pinged me about it: LGTM too

@eseidelGoogle
Copy link
Contributor

Do we have a separate bug on file about distinguishing? :) I assume so?

@cbracken
Copy link
Member Author

cbracken commented Nov 6, 2017

We do now -- the bug is flutter/flutter#12895 and is WIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants