-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[html] fix: combine backdrop filter to child container to fix rendering issue on Chromium #43392
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
678f800
to
bfbba9f
Compare
ee3f3d7
to
2d6e2e0
Compare
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
bb50a01
to
3454f55
Compare
2061cb5
to
69319a1
Compare
Golden file changes are available for triage from new commit, Click here to view. |
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
@Kingtous thanks for your contribution! is this still something you are interested in working on? How can we help you? |
@KDogeOne Thanks for your contribution; I'm going to close this PR for now but please don't hesitate to open a new one if you wish to get back to it! In the meantime I will link to it from the issue in case anyone else wants to take it over. Thanks again! |
Hi from Dora AI team, which powers by
Flutter Web
to boost devs to build their 3D websites in just few seconds. We've encountered thebackdrop-filter
problem when running in HTML mode.This PR combines the
backdrop-filter
with the interior one, which fixes flutter/flutter#129896.The reason may be the different behavior when treating
backdrop-filter
properties by Chromium, and Safari. Only Chrome seems to follow the W3C draft, mentioned by Kawalo here (https://stackoverflow.com/a/76207141/11069997), which causes the inconsistent result with canvaskit or other browsers running on HTML mode.I've tested the main problem on Chrome is that the backdrop filter should not be a leaf on the DOM node, and should be directly applied to its children. If we apply it on its children, the backdrop filter works great and has no issues with the nested backdrop filter.
This bug is reported a year ago, but it seems they do not have a schedule to fix this issue. So this workaround is
necessary now to be applied to the Flutter engine to fix the rendering problem that happens on Chromium-based browsers when running in HTML mode.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.