-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a breadcrumb for people who want to run the web tests #43865
Conversation
testing/run_tests.sh
Outdated
@@ -6,3 +6,6 @@ BUILD_VARIANT="${1:-host_debug_unopt}" | |||
CURRENT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" | |||
|
|||
python3 "${CURRENT_DIR}/run_tests.py" --variant="${BUILD_VARIANT}" --type=engine,dart,benchmarks | |||
|
|||
# This does not run the web_ui tests. To run those, use: | |||
# lib/web_ui/dev-felt test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it's lib/web_ui/dev/felt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh, that's not a nit, that's the difference between this being useful and it being completely wrong 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
…131029) flutter/engine@b5a6b1c...8ff10f5 2023-07-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hVAAd2NqYOjUF_I99... to CWNVmH6f_iryKU05E... (flutter/engine#43877) 2023-07-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 1df95f328d0c to 8662af7d9aa3 (1 revision) (flutter/engine#43876) 2023-07-21 ian@hixie.ch Add a breadcrumb for people who want to run the web tests (flutter/engine#43865) 2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 049f389db75b to bae54bbf49bd (2 revisions) (flutter/engine#43875) 2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 6f2b2e94ebbd to 049f389db75b (1 revision) (flutter/engine#43873) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from hVAAd2NqYOjU to CWNVmH6f_iry If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#131029) flutter/engine@b5a6b1c...8ff10f5 2023-07-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hVAAd2NqYOjUF_I99... to CWNVmH6f_iryKU05E... (flutter/engine#43877) 2023-07-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 1df95f328d0c to 8662af7d9aa3 (1 revision) (flutter/engine#43876) 2023-07-21 ian@hixie.ch Add a breadcrumb for people who want to run the web tests (flutter/engine#43865) 2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 049f389db75b to bae54bbf49bd (2 revisions) (flutter/engine#43875) 2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 6f2b2e94ebbd to 049f389db75b (1 revision) (flutter/engine#43873) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from hVAAd2NqYOjU to CWNVmH6f_iry If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
No description provided.