Expose Window.viewInsets in dart:ui #4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -560,10 +569,15 @@ public final WindowInsets onApplyWindowInsets(WindowInsets insets) { | |||
| @SuppressWarnings("deprecation") | |||
| protected boolean fitSystemWindows(Rect insets) { | |||
| if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.KITKAT) { | |||
| // On Android, we do no differentiate between 'safe areas' and view insets. | |||
There was a problem hiding this comment.
typo: "do no" -> "do not"
There was a problem hiding this comment.
Done. Thanks for spotting!
chinmaygarde
approved these changes
Nov 29, 2017
cbracken
force-pushed
the
iphone_x_margin
branch
from
8dafd78
to
9639092
Compare
xster
reviewed
Nov 29, 2017
lib/ui/window.dart
Outdated
| @@ -72,6 +72,40 @@ enum AppLifecycleState { | |||
| suspending, | |||
| } | |||
|
|
|||
| /// A representation of the insets relative to each side of the window into | |||
| /// which the application can render, but over white the operating system will | |||
xster
approved these changes
Nov 29, 2017
lib/ui/window.dart
Outdated
| /// | ||
| /// * [WidgetsBindingObserver], for a widgets layer mechanism to receive | ||
| /// notifications when the margin changes. | ||
| /// * [MediaQuery.of], a simpler mechanism for the same. |
There was a problem hiding this comment.
I feel this is not super clear. Is it referring to 'the same' representation of the insets or of the mechanism to receive notifications or something else?
There was a problem hiding this comment.
Updated both here and for padding for consistency.
cbracken
force-pushed
the
iphone_x_margin
branch
from
9639092
to
7b93428
Compare
Window.viewInsets is the set of window-relative insets that describe the area of the window that an application may want to treat as effectively reducing the size of the content. Typically this is due to system UI that fully obscures underlying content, such as the keyboard. This area differs from padding in that padding is the set of insets that describe the area of the window that may be partially (or fully) obscured by system UI or physical intrusions into the view area (e.g. iPhone X sensor housing, status bar, or the iPhone X home indicator widget). This patch does not yet enable the iOS bottom edge safe area. Once the framework has been updated to use viewInsets for bottom-edge occlusions (today, the keyboard), the bottom safe area will be enabled and framework patches that depend on it, landed.
cbracken
force-pushed
the
iphone_x_margin
branch
from
7b93428
to
91fe2f8
Compare
|
LG |
|
Adds underlying support for fixing flutter/flutter#12895. |
Hixie
reviewed
Nov 30, 2017
| /// * [MediaQuery.of], for the preferred mechanism for accessing this value. | ||
| /// * [Scaffold], which automatically applies the view insets in material | ||
| /// design applications. | ||
| class ViewInsets { |
There was a problem hiding this comment.
How does this class differ from WindowPadding?
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Nov 30, 2017
Also updates EdgeInsets documentation to reflect WindowPadding's use for both padding and view insets. See engine commits: flutter/engine#4403 flutter/engine#4406
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Nov 30, 2017
* Add MediaQuery support for view insets Also updates EdgeInsets documentation to reflect WindowPadding's use for both padding and view insets. See engine commits: flutter/engine#4403 flutter/engine#4406
bsalomon
pushed a commit
to bsalomon/engine
that referenced
this pull request
Dec 8, 2017
Window.viewInsets is the set of window-relative insets that describe the area of the window that an application may want to treat as effectively reducing the size of the content. Typically this is due to system UI that fully obscures underlying content, such as the keyboard. This area differs from padding in that padding is the set of insets that describe the area of the window that may be partially (or fully) obscured by system UI or physical intrusions into the view area (e.g. iPhone X sensor housing, status bar, or the iPhone X home indicator widget). This patch does not yet enable the iOS bottom edge safe area. Once the framework has been updated to use viewInsets for bottom-edge occlusions (today, the keyboard), the bottom safe area will be enabled and framework patches that depend on it, landed.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Add MediaQuery support for view insets Also updates EdgeInsets documentation to reflect WindowPadding's use for both padding and view insets. See engine commits: flutter/engine#4403 flutter/engine#4406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Window.viewInsets is the set of window-relative insets that describe the
area of the window that an application may want to treat as effectively
reducing the size of the content. Typically this is due to system UI
that fully obscures underlying content, such as the keyboard.
This area differs from padding in that padding is the set of insets that
describe the area of the window that may be partially (or fully)
obscured by system UI or physical intrusions into the view area (e.g.
iPhone X sensor housing, status bar, or the iPhone X home indicator
widget).
This patch does not yet enable the iOS bottom edge safe area. Once the
framework has been updated to use viewInsets for bottom-edge occlusions
(today, the keyboard), the bottom safe area will be enabled and
framework patches that depend on it, landed.