Switch to accept/reject-friendly incremental compiler #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Jan 30, 2018
|
LGTM though looks like it requires sync to a newer FYI The clang-format issues with vulkan_surface.cc should be resolved if you rebase on tip-of-tree. |
whesse
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 31, 2018
This is to be used in Flutter tools: flutter/engine#4601 Bug: #31919 Change-Id: Ib94562e797b3455c047ce5a9dae959375f957e5f Reviewed-on: https://dart-review.googlesource.com/37360 Commit-Queue: Alexander Aprelev <aam@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of https://dart-review.googlesource.com/c/sdk/+/37360 that introduces package:vm/incremental_compiler.dart