Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote fuchsia build v2 to prod. #47729

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Promote fuchsia build v2 to prod. #47729

merged 1 commit into from
Nov 7, 2023

Conversation

godofredoc
Copy link
Contributor

The current failure in staging is because the service account does not have write access to the release bucket.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Promote fuchsia build v2 to prod.
1dc6673 
The current failure in staging is because the service account does not
have write access to the release bucket.
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 7, 2023
@auto-submit auto-submit bot merged commit 111808f into flutter:main Nov 7, 2023
28 checks passed
@godofredoc godofredoc deleted the fuchsia_v2_pro branch November 7, 2023 21:29
@bdero bdero added the revert Label used to revert changes in a closed and merged pull request. label Nov 8, 2023
bdero added a commit that referenced this pull request Nov 8, 2023
@bdero
Revert "Promote fuchsia build v2 to prod. (#47729)"
16ddf82 
This reverts commit 111808f.
@auto-submit auto-submit bot mentioned this pull request Nov 8, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Nov 8, 2023
Revert "Promote fuchsia build v2 to prod. (#47729)"
2313605 
This reverts commit 111808f.
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Nov 8, 2023
@bdero bdero mentioned this pull request Nov 8, 2023
Closed
auto-submit bot added a commit that referenced this pull request Nov 8, 2023
@auto-submit
Reverts "Promote fuchsia build v2 to prod." (#47779)
c8195b4 
Reverts #47729
Initiated by: bdero
This change reverts the following previous change:
Original Description:
The current failure in staging is because the service account does not have write access to the release bucket.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2023
@engine-flutter-autoroll
111808f3f Promote fuchsia build v2 to prod. (flutter/engine#47729)
3952224
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 8, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2023
@engine-flutter-autoroll
111808f3f Promote fuchsia build v2 to prod. (flutter/engine#47729)
927ae0e
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 8, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 3e3be5e33bda to 117d47aa3f88 (20 revisions) (#…
dbb79e6 
…138091)

flutter/engine@3e3be5e...117d47a

2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from fce71a80b0a2 to a4cce5236dcf (1 revision) (flutter/engine#47807)
2023-11-08 chris@bracken.jp [macOS] Clean up resources in ViewController tests (flutter/engine#47792)
2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from f3d250126ba9 to fce71a80b0a2 (1 revision) (flutter/engine#47796)
2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from b4fa927468e6 to f3d250126ba9 (1 revision) (flutter/engine#47793)
2023-11-08 flar@google.com [Impeller] Add Rect::GetNormalizingTransform to handle UV coordinate conversion (flutter/engine#47775)
2023-11-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove Fuchsia Mac SDK from DEPS" (flutter/engine#47791)
2023-11-08 yjbanov@google.com [web] fix clicks on merged semantic nodes (attempt #2) (flutter/engine#47360)
2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from 0f78e5f765d3 to b4fa927468e6 (1 revision) (flutter/engine#47788)
2023-11-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VcFEJiUUTYwkhEAlJ... to sD8HRA4JmXczujkqO... (flutter/engine#47785)
2023-11-08 jiahaog@users.noreply.github.com Fix narrowing conversion lint (flutter/engine#47740)
2023-11-08 chris@bracken.jp [macOS] Bail out of tests if engine not running (flutter/engine#47771)
2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from f91d39395e85 to 0f78e5f765d3 (1 revision) (flutter/engine#47776)
2023-11-08 chris@bracken.jp [testing] Extract StreamCapture test utility (flutter/engine#47774)
2023-11-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Promote fuchsia build v2 to prod." (flutter/engine#47779)
2023-11-08 aam@google.com Include updated locations for dart third_party components into license ignore-list. (flutter/engine#47770)
2023-11-07 chillers@google.com Remove Fuchsia Mac SDK from DEPS (flutter/engine#47700)
2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from 030e21befbc9 to f91d39395e85 (6 revisions) (flutter/engine#47769)
2023-11-07 chinmaygarde@google.com [Impeller] Support static thread safety analysis with condition variables. (flutter/engine#47763)
2023-11-07 godofredoc@google.com Promote fuchsia build v2 to prod. (flutter/engine#47729)
2023-11-07 737941+loic-sharma@users.noreply.github.com [Windows] Reduce warnings produced by unit tests (flutter/engine#47724)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from VcFEJiUUTYwk to sD8HRA4JmXcz

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@godofredoc @zanderso @bdero