Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linux_android_emulator_api_33 build config for rbe #49776

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

zanderso
Copy link
Member

Following up from #49660. Missed this bringup: true shard.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnmccutchan
Copy link
Contributor

test-exempt: config change

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 12, 2024
auto-submit bot pushed a commit to flutter/cocoon that referenced this pull request Jan 12, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 12, 2024
Copy link
Contributor

auto-submit bot commented Jan 12, 2024

auto label is removed for flutter/engine/49776, due to - The status or check suite Linux mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 12, 2024
@auto-submit auto-submit bot merged commit 2cad45d into main Jan 12, 2024
31 checks passed
@auto-submit auto-submit bot deleted the zanderso-patch-5 branch January 12, 2024 23:33
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 13, 2024
…141496)

flutter/engine@205ed68...b06478b

2024-01-12 dnfield@google.com [Impeller] Properly size struct emplacements for Vulkan Runtime Effects (flutter/engine#49768)
2024-01-12 zanderso@users.noreply.github.com Fix linux_android_emulator_api_33 build config for rbe (flutter/engine#49776)
2024-01-12 dkwingsmt@users.noreply.github.com [Linux] Remove the usage of std::function in FlKeyEmbedderResponder (flutter/engine#49293)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants