Use any mac machine available for orchestrator run. #49845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will remove some of the stress on x64 machines and will help to get faster builds on dart-internal.
|
Tested the change running all the orchestrators using arm64 and they all passed presubmit. |
zanderso
approved these changes
Jan 18, 2024
godofredoc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 18, 2024
…141800) flutter/engine@75400c4...f4a4f04 2024-01-18 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fall back to multi-context rendering on Firefox and Safari (flutter/engine#49572) 2024-01-18 godofredoc@google.com Use any mac machine available for orchestrator run. (flutter/engine#49845) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
godofredoc
added a commit
to godofredoc/engine
that referenced
this pull request
Jan 18, 2024
This will remove some of the stress on x64 machines and will help to get faster builds on dart-internal. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
) This will remove some of the stress on x64 machines and will help to get faster builds on dart-internal. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove some of the stress on x64 machines and will help to get faster builds on dart-internal.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.