Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] Wire up Angle use to a command line flag and enable it by default on macOS. #50304

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

chinmaygarde
Copy link
Member

Similar to --use_swiftshader in #50298.

@chinmaygarde
Copy link
Member Author

chinmaygarde commented Feb 2, 2024

For the first time ever, we can compile, run, frame-capture, and profile all backends on macOS. This is awesome.

Screenshot 2024-02-02 at 1 46 27 PM

Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 2, 2024
@auto-submit auto-submit bot merged commit fee0214 into flutter:main Feb 2, 2024
28 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 3, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 3, 2024
…142847)

flutter/engine@9869d47...fee0214

2024-02-02 chinmaygarde@google.com [Impeller] Wire up Angle use to a command line flag and enable it by default on macOS. (flutter/engine#50304)
2024-02-02 jason-simmons@users.noreply.github.com Remove the skia_fontmgr_factory argument from the Web GN configuration (flutter/engine#50183)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@chinmaygarde chinmaygarde deleted the use_angle branch August 22, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants