Redo "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds" #50408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g/fuchsi…" This reverts commit 269ed90.
zijiehe-google-com
changed the title
|
Changes LGTM, but I'd like @jrwang to review as it impacts Fuchsia to disable LTO. |
|
Thank you Casey and Jonny. |
zijiehe-google-com
deleted the
revert-50407-revert_a09980eec32705ee402c75aef99f4e99d8bda64f
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 7, 2024
…ites.yaml on debug and release builds" (flutter/engine#50408)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 7, 2024
…143094) flutter/engine@fafd8e5...19ae46a 2024-02-07 68449066+zijiehe-google-com@users.noreply.github.com Redo "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds" (flutter/engine#50408) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #50407, flutter/flutter#142811, redo #50058.
Comparing to the original change, this redo disabled lto / link time optimization for x64 release builder. It's a known issue that lto increased the compilation time from <5 min to over 30 min. (See commit a1b104c.)
Disabling lto is safe on x64 release since fuchsia assembly uses arm64 release build on smart display instead. But I will send a PSA to the fuchsia team before submitting this change.
Following is the original change description.
This change implements a BundledTestRunner to run most of the tests in testing/fuchsia/test_suites.yaml as ExecutableTestRunner.
The BundledTestRunner can share most of the logic in ExecutableTestRunner and avoid reinventing the wheel.
This change also fixes the build break of fuchsia_tests in fuchsia_release_x64 which allows tests to run on the build as well.
Bug: flutter/flutter#140179
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.