Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up additional NDK helper related code #50518

Merged
merged 6 commits into from
Feb 10, 2024
Merged

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Feb 9, 2024

Moves more dlsym related code to ndk_helpers.h/cc.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 9, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 9, 2024
Copy link
Contributor

auto-submit bot commented Feb 9, 2024

auto label is removed for flutter/engine/50518, due to - The status or check suite Linux linux_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 10, 2024
@auto-submit auto-submit bot merged commit e08b6c8 into flutter:main Feb 10, 2024
31 checks passed
@dnfield dnfield deleted the swapchain branch February 10, 2024 01:53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 10, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 10, 2024
…143264)

flutter/engine@1b8f23b...e08b6c8

2024-02-10 dnfield@google.com Clean up additional NDK helper related code (flutter/engine#50518)
2024-02-09 tugorez@users.noreply.github.com Make the web engine publish view forward focus and unfocus events (flutter/engine#50177)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants