[Impeller] replaced playground macros with functions #50602
Conversation
| Color::White(), Color::White()); | ||
| static PlaygroundPoint point_a(Point(50, 50), 30, Color::White()); | ||
| static PlaygroundPoint point_b(Point(300, 200), 30, Color::White()); | ||
| auto [a, b] = DrawPlaygroundLine(point_a, point_b); |
There was a problem hiding this comment.
If the intention behind this is change is make tests where these are used golden-able, would just changing the macros to forward defaults when IMPELLER_GOLDEN_TESTS is enabled work?
There was a problem hiding this comment.
The intention is to get this code compliant with the c++ style guide: https://google.github.io/styleguide/cppguide.html#Preprocessor_Macros
My next PR will get these running in golden image tests. This is just cleanup. That's an interesting idea with IMPELLER_GOLDEN_TESTS. I will probably avoid latching more decisions on preprocessor macros and instead rely on AiksPlayground vs GoldenPlayground.
There was a problem hiding this comment.
Oh cool, I was able to just gate the logic on the presence of an ImGui context. I'll include you in the follow up PR.
There was a problem hiding this comment.
Makes sense... At some point we could change this to use ImGui's actual identity/storage system so that they can remain as one function without the statics. Added an issue here.
|
I was late to the party, but this was also LGTM ;) |
…143393) flutter/engine@8742f1c...0091a49 2024-02-13 jonahwilliams@google.com [Impeller] remove denylist entry. (flutter/engine#50605) 2024-02-13 zanderso@users.noreply.github.com [engine_build_configs] Use dart:ffi Abi to determine the host cpu (flutter/engine#50604) 2024-02-13 jason-simmons@users.noreply.github.com Update embedder support for Impeller/OpenGL to load some missing shaders and configure a depth attachment (flutter/engine#50416) 2024-02-13 skia-flutter-autoroll@skia.org Roll Skia from 30bba7419898 to f7e3a5395fe1 (1 revision) (flutter/engine#50603) 2024-02-13 30870216+gaaclarke@users.noreply.github.com [Impeller] replaced playground macros with functions (flutter/engine#50602) 2024-02-13 matanlurey@users.noreply.github.com Allow deprecated members from the Dart SDK to roll in. (flutter/engine#50575) 2024-02-13 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run tests with test arguments (flutter/engine#50478) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
testing: Refactor only
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.