[Windows] Make the engine create the view #50673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
loic-sharma
force-pushed
the
windows_ownership_2
branch
from
d447004
to
c002f88
Compare
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
_This was split from #50673 to reduce noise in that PR._ Previously `MockFlutterWindow` called a `FlutterWindow` constructor which created a window & resized it. This change introduces a minimal base constructor for testing purposes. This allows us to skip some noisy mocks in a subsequent change: #50673 This also introduces a fixture for the window unit tests. Part of flutter/flutter#137267 Part of flutter/flutter#142845 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
loic-sharma
force-pushed
the
windows_ownership_2
branch
from
c002f88
to
b1fb925
Compare
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 20, 2024
…143763) flutter/engine@a41da37...e16a260 2024-02-20 737941+loic-sharma@users.noreply.github.com [Windows] Make the engine create the view (flutter/engine#50673) 2024-02-20 skia-flutter-autoroll@skia.org Roll Skia from 2f9bb1517740 to 2dc00a705f1c (2 revisions) (flutter/engine#50782) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the Windows engine create views. Benefits:
Part of flutter/flutter#137267
Part of flutter/flutter#142845
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.