Make global builds uniquely named per platform #50764
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
force-pushed
the
check-configs
branch
2 times, most recently
from
61bbb2c
to
578f7f9
Compare
| @@ -1,14 +1,6 @@ | |||
| { | |||
| "builds": [ | |||
| { | |||
| "archives": [ | |||
There was a problem hiding this comment.
I think these should not have been getting uploaded. @godofredoc had a PR to remove these awhile back, but it got reverted for a different reason.
zanderso
force-pushed
the
check-configs
branch
from
578f7f9
to
c452945
Compare
zanderso
force-pushed
the
check-configs
branch
from
c452945
to
4c24fe1
Compare
…143816) flutter/engine@7002504...efc6994 2024-02-21 zanderso@users.noreply.github.com Make global builds uniquely named per platform (flutter/engine#50764) 2024-02-21 zanderso@users.noreply.github.com [et] Adds a format command (flutter/engine#50747) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This is expected to help with flutter/flutter#132807