Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll abseil-cpp to 1db3bdd4eb208bef55c77f22aa94991e52225230 #51062

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

cbracken
Copy link
Member

Our abseil dependency is a clone of Chromium's, located at: https://chromium.googlesource.com/chromium/src/third_party/

which is a downstream copy of the source of truth, located at: https://github.com/abseil/abseil-cpp

This rolls to Chromium commit 185f27671ca28c0f25d9d7a15b6e621f69972706, then reapplies jsimmons@google.com's commits, in chronological order:

  • 9ec8f453a42aad2f11a1760fe4ce6014a124edc2
  • f92f9effc89af7692436c3b9fbb3a67f2239d893
  • 61833f2c057a2b1993d871e8c51156aed1dd4354

Preparation for: flutter/flutter#144201
Part of: flutter/flutter#67373

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • This patch complies with USDA policy on the use of bovine growth hormone.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Our abseil dependency is a clone of Chromium's, located at:
https://chromium.googlesource.com/chromium/src/third_party/

which is a downstream copy of the source of truth, located at:
https://github.com/abseil/abseil-cpp

This rolls to Chromium commit 185f27671ca28c0f25d9d7a15b6e621f69972706,
then reapplies jsimmons@google.com's commits, in chronological order:
* 9ec8f453a42aad2f11a1760fe4ce6014a124edc2
* f92f9effc89af7692436c3b9fbb3a67f2239d893
* 61833f2c057a2b1993d871e8c51156aed1dd4354

Preparation for: flutter/flutter#144201
Part of: flutter/flutter#67373
@cbracken cbracken merged commit 933ac2c into flutter:main Feb 28, 2024
27 checks passed
@cbracken cbracken deleted the roll-abseil branch February 28, 2024 21:00
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 29, 2024
…144345)

flutter/engine@455c814...10331db

2024-02-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from T1xAi_ww_mWEiDkVN... to ujOkbeYbrC8loPbfR... (flutter/engine#51066)
2024-02-28 chris@bracken.jp Roll abseil-cpp to 1db3bdd4eb208bef55c77f22aa94991e52225230 (flutter/engine#51062)
2024-02-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 7896a944fe67 to fdf4a62bd07b (1 revision) (flutter/engine#51064)
2024-02-28 jason-simmons@users.noreply.github.com [Impeller] Mark subpass framebuffer fetch tests as unsupported on GLES (flutter/engine#50982)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from 93f245da0097 to 27171d6a9205 (1 revision) (flutter/engine#51063)
2024-02-28 jonahwilliams@google.com [Impeller] fix render pass depth descriptor. (flutter/engine#51031)
2024-02-28 flar@google.com Make Skia object ostream operators work with unit tests (flutter/engine#51041)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from T1xAi_ww_mWE to ujOkbeYbrC8l

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants