Add device selection to et run
#51184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Mar 5, 2024
johnmccutchan
force-pushed
the
et_run2
branch
2 times, most recently
from
6aa951d
to
b330ea6
Compare
- `et run` now detects the target device automatically and builds the related engine builds. - `et run -- -d <device-id>` also works.
zanderso
approved these changes
Mar 5, 2024
johnmccutchan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 5, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 5, 2024
…144639) flutter/engine@3e8b0de...49bc157 2024-03-05 zanderso@users.noreply.github.com Fix typo in githook message (flutter/engine#51205) 2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 453cb0d04584 to 875b356e4d96 (2 revisions) (flutter/engine#51202) 2024-03-05 john@johnmccutchan.com Add device selection to `et run` (flutter/engine#51184) 2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from de108a9c8b54 to 453cb0d04584 (2 revisions) (flutter/engine#51201) 2024-03-05 zanderso@users.noreply.github.com Adds githooks that reminds to run `gclient sync -D` (flutter/engine#51156) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
et runnow detects the target device automatically and builds the related engine builds.et run -- -d <device-id>also works.