Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Add DisplayList Region and Transform benchmarks to CI" #51458

Merged

Conversation

flar
Copy link
Contributor

@flar flar commented Mar 15, 2024

Reverts #51432

Originally landed as #51429, but the appropriate executables were not listed in the standalone build files.

@flar flar added the test: all See https://github.com/flutter/engine/blob/main/docs/ci/Engine-pre-submits-and-post-submits.md label Mar 15, 2024
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flar
Copy link
Contributor Author

flar commented Mar 15, 2024

Test exemption should be implicit since there are no code changes here.

Pull request was created with test: all label to hopefully catch errors in executing the new CI tasks during pre-submit.

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 15, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 15, 2024
Copy link
Contributor

auto-submit bot commented Mar 15, 2024

auto label is removed for flutter/engine/51458, due to - The status or check suite Linux linux_android_emulator_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

These benchmark results aren't shown in Skia perf because they were never added to the CI tasks to run.
@flar flar force-pushed the reland-dl-region-transform-benchmarks-ci-tasks branch from 157cb34 to 9fd3d47 Compare March 16, 2024 00:39
@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2024
@auto-submit auto-submit bot merged commit 6ddaa40 into flutter:main Mar 16, 2024
31 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 16, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 16, 2024
…145250)

flutter/engine@d46c1fa...6ddaa40

2024-03-16 flar@google.com Reland "Add DisplayList Region and Transform benchmarks to CI" (flutter/engine#51458)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App test: all See https://github.com/flutter/engine/blob/main/docs/ci/Engine-pre-submits-and-post-submits.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants