Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fl_standard_method_codec_new_with_message_codec() #51599

Conversation

robert-ancell
Copy link
Contributor

Matches constructor in https://api.flutter.dev/flutter/services/StandardMethodCodec-class.html and is required to make method calls with custom value types.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-ancell robert-ancell merged commit efdde39 into flutter:main Mar 25, 2024
23 checks passed
@robert-ancell robert-ancell deleted the linux-method-codec-with-message-codec branch March 25, 2024 01:06
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 25, 2024
…145668)

flutter/engine@0734f47...efdde39

2024-03-25 robert.ancell@canonical.com Add fl_standard_method_codec_new_with_message_codec() (flutter/engine#51599)
2024-03-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from IPZvFWIGJFJnJ409e... to ySBsQPn-0UgTQaXIw... (flutter/engine#51649)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from IPZvFWIGJFJn to ySBsQPn-0UgT

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants