-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a minimal example of using package:test
.
#51726
Conversation
@@ -0,0 +1,13 @@ | |||
import 'package:test/test.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Needs the engine copyright header.
(Hopefully when we finish the buildmoot, this can be enforced by a tool.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
analysis_options.yaml
Outdated
- examples/ | ||
- impeller/ | ||
- prebuilts/ | ||
- runtime/ | ||
- shell/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these excluded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot, this leaked in from another PR (the multi-pub one). Reverting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I actually think it makes sense to exclude them still, but let's do it in a standalone PR so I can explain why)
…146001) flutter/engine@7176173...8480145 2024-03-29 matanlurey@users.noreply.github.com Add a minimal example of using `package:test`. (flutter/engine#51726) 2024-03-29 matanlurey@users.noreply.github.com Implement `.engine-release.version` files for engine Skia Gold tests (flutter/engine#51739) 2024-03-29 mdebbar@google.com [web] Use viewId for text editing (flutter/engine#51099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Work towards flutter/flutter#133569.
This PR is a proof of concept that shows we're able to use
package:test
influtter/engine
instead ofpackage:litetest
.I think it also shows that, if we're going to continue to vend dependencies this way, we might want to re-think our strategy in terms of using
pub
as a management tool - it's quite unwieldy already. For example, here is everypubspec.yaml
file in the repo:I'll file a follow-up issue to discuss pub-package management in the engine.