Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md links #53043

Merged
merged 2 commits into from
May 29, 2024
Merged

Update CONTRIBUTING.md links #53043

merged 2 commits into from
May 29, 2024

Conversation

jtmcdole
Copy link
Contributor

engine_dev_setup moved to markdown

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

`engine_dev_setup` moved to markdown
@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2024
@auto-submit auto-submit bot merged commit fdb91b1 into flutter:main May 29, 2024
27 checks passed
@jtmcdole jtmcdole deleted the docs branch May 29, 2024 22:46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 30, 2024
…149290)

flutter/engine@8d5d14a...4adf453

2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from aecf76e8eb9a to f23183f041fe (1 revision) (flutter/engine#53102)
2024-05-29 john@mcdole.org Update CONTRIBUTING.md links (flutter/engine#53043)
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from 32746679f7be to aecf76e8eb9a (1 revision) (flutter/engine#53100)
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from b18b7d6af6e8 to 32746679f7be (2 revisions) (flutter/engine#53097)
2024-05-29 jonahwilliams@google.com [Impeller] revert changes to IO thread upload scheduling. (flutter/engine#53096)
2024-05-29 jonahwilliams@google.com [Impeller] fix barriers prior to mip generation. (flutter/engine#53082)
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from e11a5c5b402e to b18b7d6af6e8 (2 revisions) (flutter/engine#53095)
2024-05-29 goderbauer@google.com Switch to FilterQuality.medium for images (flutter/engine#52984)
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from a4f58c9dabc3 to e11a5c5b402e (1 revision) (flutter/engine#53092)
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from ca77972f659e to a4f58c9dabc3 (2 revisions) (flutter/engine#53091)
2024-05-29 jonahwilliams@google.com [Impeller] relax conditions for SkRRect.isSimple conversion to impeller::RRect. (flutter/engine#53083)
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from d1a6967c48a5 to ca77972f659e (1 revision) (flutter/engine#53090)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
…lutter#149290)

flutter/engine@8d5d14a...4adf453

2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from aecf76e8eb9a to f23183f041fe (1 revision) (flutter/engine#53102)
2024-05-29 john@mcdole.org Update CONTRIBUTING.md links (flutter/engine#53043)
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from 32746679f7be to aecf76e8eb9a (1 revision) (flutter/engine#53100)
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from b18b7d6af6e8 to 32746679f7be (2 revisions) (flutter/engine#53097)
2024-05-29 jonahwilliams@google.com [Impeller] revert changes to IO thread upload scheduling. (flutter/engine#53096)
2024-05-29 jonahwilliams@google.com [Impeller] fix barriers prior to mip generation. (flutter/engine#53082)
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from e11a5c5b402e to b18b7d6af6e8 (2 revisions) (flutter/engine#53095)
2024-05-29 goderbauer@google.com Switch to FilterQuality.medium for images (flutter/engine#52984)
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from a4f58c9dabc3 to e11a5c5b402e (1 revision) (flutter/engine#53092)
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from ca77972f659e to a4f58c9dabc3 (2 revisions) (flutter/engine#53091)
2024-05-29 jonahwilliams@google.com [Impeller] relax conditions for SkRRect.isSimple conversion to impeller::RRect. (flutter/engine#53083)
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from d1a6967c48a5 to ca77972f659e (1 revision) (flutter/engine#53090)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants