Reland "Output .js files as ES6 modules. (#52023)" #53688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
reviewed
Jul 2, 2024
auto-submit bot
pushed a commit
to flutter/buildroot
that referenced
this pull request
Jul 3, 2024
) To go with the reland of ES6 modules stuff here: flutter/engine#53688
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 3, 2024
…151208) flutter/engine@4427894...c5c0c54 2024-07-03 jacksongardner@google.com Reland "Output .js files as ES6 modules. (#52023)" (flutter/engine#53688) 2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from d02998fba957 to 7c69f39fa85b (1 revision) (flutter/engine#53701) 2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from c1f2dd0fc5f6 to d02998fba957 (2 revisions) (flutter/engine#53699) 2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from c0ee0e108900 to c1f2dd0fc5f6 (2 revisions) (flutter/engine#53697) 2024-07-02 flar@google.com [Impeller] fix typo in setup for fast elliptical rrect blurs (flutter/engine#53673) 2024-07-02 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from RgErspyYHapUO2Spc... to sbh76PYVTMxav4ACT... (flutter/engine#53693) 2024-07-02 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed units for memory measurement (flutter/engine#53687) 2024-07-02 jhy03261997@gmail.com [deep link][ios] Update openURL method to reflect the result from framework (flutter/engine#52643) 2024-07-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from c23e58143793 to ffc8bb004a64 (2 revisions) (flutter/engine#53690) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Reason for revert: canvaskit.js cannot be loaded in an internal end to end test - see b/350885206 |
jiahaog
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Jul 3, 2024
…#53709) Reverts: #53688 Initiated by: jiahaog Reason for reverting: canvaskit.js cannot be loaded in an internal end to end test - see b/350885206 Original PR Author: eyebrowsoffire Reviewed By: {ditman} This change reverts the following previous change: This is an attempt to reland #52023. The issue previously is that if it was not specified by the user, the default CanvasKit base URL did not have a leading slash, which does not work when doing dynamic imports.
TahaTesser
pushed a commit
to TahaTesser/flutter
that referenced
this pull request
Jul 8, 2024
…lutter#151208) flutter/engine@4427894...c5c0c54 2024-07-03 jacksongardner@google.com Reland "Output .js files as ES6 modules. (flutter#52023)" (flutter/engine#53688) 2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from d02998fba957 to 7c69f39fa85b (1 revision) (flutter/engine#53701) 2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from c1f2dd0fc5f6 to d02998fba957 (2 revisions) (flutter/engine#53699) 2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from c0ee0e108900 to c1f2dd0fc5f6 (2 revisions) (flutter/engine#53697) 2024-07-02 flar@google.com [Impeller] fix typo in setup for fast elliptical rrect blurs (flutter/engine#53673) 2024-07-02 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from RgErspyYHapUO2Spc... to sbh76PYVTMxav4ACT... (flutter/engine#53693) 2024-07-02 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed units for memory measurement (flutter/engine#53687) 2024-07-02 jhy03261997@gmail.com [deep link][ios] Update openURL method to reflect the result from framework (flutter/engine#52643) 2024-07-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from c23e58143793 to ffc8bb004a64 (2 revisions) (flutter/engine#53690) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
…lutter#151208) flutter/engine@4427894...c5c0c54 2024-07-03 jacksongardner@google.com Reland "Output .js files as ES6 modules. (flutter#52023)" (flutter/engine#53688) 2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from d02998fba957 to 7c69f39fa85b (1 revision) (flutter/engine#53701) 2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from c1f2dd0fc5f6 to d02998fba957 (2 revisions) (flutter/engine#53699) 2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from c0ee0e108900 to c1f2dd0fc5f6 (2 revisions) (flutter/engine#53697) 2024-07-02 flar@google.com [Impeller] fix typo in setup for fast elliptical rrect blurs (flutter/engine#53673) 2024-07-02 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from RgErspyYHapUO2Spc... to sbh76PYVTMxav4ACT... (flutter/engine#53693) 2024-07-02 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed units for memory measurement (flutter/engine#53687) 2024-07-02 jhy03261997@gmail.com [deep link][ios] Update openURL method to reflect the result from framework (flutter/engine#52643) 2024-07-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from c23e58143793 to ffc8bb004a64 (2 revisions) (flutter/engine#53690) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to reland #52023. The issue previously is that if it was not specified by the user, the default CanvasKit base URL did not have a leading slash, which does not work when doing dynamic imports.