Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Locale.fromSubtags and support for scriptCode. #6518

Merged
merged 27 commits into from
Oct 29, 2018
Merged

Add Locale.fromSubtags and support for scriptCode. #6518

merged 27 commits into from
Oct 29, 2018

Commits on Oct 12, 2018

  1. Add Locale.fromComponents.

    @hugovdm
    hugovdm committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    e042526 View commit details
    Browse the repository at this point in the history

  2. Change toString from underscores to dashes. Expand the unit tests.

    @hugovdm
    hugovdm committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    4013600 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2018

  1. Rename 'fromComponents' to 'create'. Change variants from String to L… 

    …ist<String>.
    @hugovdm
    hugovdm committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    813998d View commit details
    Browse the repository at this point in the history

  2. Use default for language parameter. Use hashCode/hashList.

    @hugovdm
    hugovdm committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    fe5e110 View commit details
    Browse the repository at this point in the history

  3. Have toString() stick with old (underscore) behaviour.

    @hugovdm
    hugovdm committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    fb72be0 View commit details
    Browse the repository at this point in the history

  4. Demonstrate empty-list bug in assert code.

    @hugovdm
    hugovdm committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    c6a8b96 View commit details
    Browse the repository at this point in the history

  5. Fix empty-list assert bug.

    @hugovdm
    hugovdm committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    af40b72 View commit details
    Browse the repository at this point in the history

  6. Add ignores for lint issues. Unsure about 71340 though.

    @hugovdm
    hugovdm committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    488cf31 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2018

  1. Fix operator== via _listEquals.

    @hugovdm
    hugovdm committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    829af35 View commit details
    Browse the repository at this point in the history

  2. Remove length-checking asserts: we're anyway not checking characters … 

    …in fields.
    @hugovdm
    hugovdm committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    c749663 View commit details
    Browse the repository at this point in the history

  3. Documentation update.

    @hugovdm
    hugovdm committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    04c52e9 View commit details
    Browse the repository at this point in the history

  4. Change reasoning for ignore:prefer_initializing_formals.

    @hugovdm
    hugovdm committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    58bfdc6 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2018

  1. Try 'fromSubtags' as new constructor name.

    @hugovdm
    hugovdm committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    bc4cc07 View commit details
    Browse the repository at this point in the history

  2. Documentation improvements based on Pull Request review.

    @hugovdm
    hugovdm committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    a8b2797 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2018

  1. Assert-fail for invalid-length subtags and drop bad subtags in produc… 

    …tion code.
    @hugovdm
    hugovdm committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    d6f06f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2018

  1. Revert "Assert-fail for invalid-length subtags and drop bad subtags i… 

    …n production code."

This reverts commit d6f06f5.
    @hugovdm
    hugovdm committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    8948502 View commit details
    Browse the repository at this point in the history

  2. Re-fix Locale.toString() for variants=[].

    @hugovdm
    hugovdm committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    20e8bd7 View commit details
    Browse the repository at this point in the history

  3. Tear out variants, in case we want to have one fewer pointer in the f… 

    …uture.
    @hugovdm
    hugovdm committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    9911dfd View commit details
    Browse the repository at this point in the history

  4. Make named parameters' names consistent with member names.

    @hugovdm
    hugovdm committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    cb81b55 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2018

  1. Also remove _listEquals: no longer in use.

    @hugovdm
    hugovdm committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    5e0def8 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2018

  1. Merge branch 'master' into fromComponents

    @hugovdm
    hugovdm authored Oct 23, 2018
    Configuration menu
    Copy the full SHA
    9f6e3e0 View commit details
    Browse the repository at this point in the history

  2. Lint fix.

    @hugovdm
    hugovdm committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    97ab4fe View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2018

  1. Fix code review nits.

    @hugovdm
    hugovdm committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    5f625ae View commit details
    Browse the repository at this point in the history

  2. Lint fix for assert, and a couple more not-zero-length-string asserts.

    @hugovdm
    hugovdm committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    3b87068 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2018

  1. Code Review: two of three nits addressed...

    @hugovdm
    hugovdm committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    df46762 View commit details
    Browse the repository at this point in the history

  2. Review fix: change 'should' to 'must' for subtag prescriptions.

    @hugovdm
    hugovdm committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    57b068e View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2018

  1. Assert-check that countryCode is never ''.

    @hugovdm
    hugovdm committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    6f07e8d View commit details
    Browse the repository at this point in the history