Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[engine] Fix builds targeting Android from a Windows host gen_snapshot #9190

Merged
merged 2 commits into from
Jun 8, 2019

Conversation

chinmaygarde
Copy link
Member

No description provided.

@chinmaygarde
Copy link
Member Author

Needs to land after flutter/buildroot#258 is rolled in.

Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde
Copy link
Member Author

xref flutter/flutter#33696

@chinmaygarde chinmaygarde merged commit e8ee6ac into flutter:master Jun 8, 2019
@chinmaygarde chinmaygarde deleted the winfix branch June 8, 2019 05:46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2019
huqiuser pushed a commit to huqiuser/engine that referenced this pull request Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants