Log dlopen errors in opt builds #41477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the Engine uses `dlopen` to find the `libapp.so`, flutter/flutter#59834 can happen which will prevent `dlopen` from finding the binary. In theory this should be mitigated by flutter#9762, but an internal customer observed errors where `dlopen` is not found. The additional logging here can help to rule out that hypothesis. For Googlers, see b/276657840 for more details.
zanderso
approved these changes
Apr 25, 2023
| @@ -13,8 +13,8 @@ NativeLibrary::NativeLibrary(const char* path) { | |||
| ::dlerror(); | |||
| handle_ = ::dlopen(path, RTLD_NOW); | |||
| if (handle_ == nullptr) { | |||
| FML_DLOG(ERROR) << "Could not open library '" << path << "' due to error '" | |||
| << ::dlerror() << "'."; | |||
| FML_LOG(ERROR) << "Could not open library '" << path << "' due to error '" | |||
There was a problem hiding this comment.
Since this will add a little misleading log spam on systems where falling back to the fully qualified path is expected, let's file an issue and add a TODO() here to shift this back to a DLOG when the investigation is complete.
jiahaog
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 26, 2023
…125549) flutter/engine@87f5f4e...321f801 2023-04-26 jiahaog@users.noreply.github.com Log dlopen errors in opt builds (flutter/engine#41477) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jiahaog
added a commit
to jiahaog/flutter-engine
that referenced
this pull request
Jul 14, 2023
This reverts commit 321f801. This didn't seem to help with debugging b/276657840. Fixes flutter/flutter#125523.
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
This reverts commit 321f801. This didn't seem to help with debugging b/276657840. Fixes flutter/flutter#125523. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Jul 20, 2023
This reverts commit 321f801. This didn't seem to help with debugging b/276657840. Fixes flutter/flutter#125523. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Engine uses
dlopento find thelibapp.so, flutter/flutter#59834 can happen which will preventdlopenfrom finding the binary. In theory this should be mitigated by #9762, but an internal customer observed errors that could be related.The additional logging here can help to rule out that hypothesis. For Googlers, see b/276657840 for more details.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.