Missing add @required arg quickfix for FloatingActionButton.

[pq]

A FloatingActionButton with no onPressed gets a warning but no associated quick-fix.

[pq]

Doing some spelunking.

Interestingly, the fix appears to be created by DAS:

{"error"::{"severity"::"INFO","type"::"HINT","location"::{"file"::"/Users/pquitslund/IdeaProjects/untitled9_111/untitled9_111_OVERRIDDEN/lib/main.dart","offset"::2156,"length"::20,"startLine"::66,"startColumn"::22},"message"::"The parameter 'onPressed' is required.","correction"::"","code"::"missing_required_param","hasFix"::false},"fixes"::[{"message"::"Add required argument 'onPressed'","edits"::[{"file"::"/Users/pquitslund/src/git/clones/flutter/packages/flutter/lib/src/material/floating_action_button.dart","fileStamp"::0,"edits"::[{"offset"::2177,"length"::0,"replacement"::"onPressed:: null"}]}],"linkedEditGroups"::[]}]}]}}

Also interesting is that the fixes to suppress the error are missing:

Current hypothesis is that something is happening on the Dart Plugin side to filter out these fixes. Still digging...

[pq]

@alexander-doroshko: I wonder if you have any ideas?

I'm stepping through things in the Dart Plugin but the flow is unfamiliar to me (and it's looking a bit complex).

I've confirmed that I'm getting these fixes back from DAS in com.jetbrains.lang.dart.analyzer.DartAnalysisServerService#askForFixesAndWaitABitIfReceivedQuickly

and that onError is not being called but somehow these fixes are not showing up and we're only seeing the assists.

Any thoughts?

If you want to reproduce, this is my test file:

import 'package:flutter/material.dart';

main() {
  FloatingActionButton button = new FloatingActionButton();
}

[pq]

More context @alexander-doroshko. This fix does appear when the @required parameter is defined locally.

So at least sometimes it is available. Also notable is that the suppress action is still not visible.

[alexander-doroshko]

Bingo!
See the quick fix received from the server that you pasted in your 1st comment. It suggests to edit the file from the Flutter SDK! Luckily the IDE is smart enough to ignore this buggy quick fix :)

"file"::"/Users/pquitslund/src/git/clones/flutter/packages/flutter/lib/src/material/floating_action_button.dart"

[pq]

AHA!

Thanks a million for helping track this down. I'll go fix the fix in the SDK.

Looks like I owe you another beer! :) 🍻

[pq]

https://codereview.chromium.org/2749373002/ 🤘

[pq]

🎉