Re-enable attach button for add-to-app projects #4062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Nov 7, 2019
| if (settings == null) { | ||
| enabled = false; | ||
| } | ||
| else { | ||
| RunConfiguration configuration = settings.getConfiguration(); | ||
| enabled = configuration instanceof SdkRunConfig; | ||
| } | ||
| e.getPresentation().setVisible(true); |
There was a problem hiding this comment.
I assume that we do want this visible even if enabled == false? We'll want it visible for Flutter enabled projects, just not enabled if if doesn't apply to the currently running app?
There was a problem hiding this comment.
Yes, it would be disabled if the run config is for Android, and enabled when a Flutter run config is selected.
alexander-doroshko
pushed a commit
to alexander-doroshko/flutter-intellij
that referenced
this pull request
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntelliJ seems to have tightened the expectations on UI performance, and we may be lagging.
The event used here changes status from running to canceled by the time the code at line 107 executes. Once canceled, we can't get the project anymore.
Also, Android apps (without Flutter) won't display the attach button. After a module is added the button needs to be made visible again (without restarting the IDE).