Skip to content

Conversation

pq
Copy link
Collaborator

@pq pq commented Jul 22, 2025

Logger.error(object) is deprecated and the String API is preferred.

https://github.com/JetBrains/intellij-community/blob/8e46815dd140357c19061ceba77416d40d81866d/platform/util/src/com/intellij/openapi/diagnostic/Logger.java#L378

(This logging isn't awesome and maybe we'll revisit but at least the API calls are clean.)

Verifier output:

      #Deprecated method com.intellij.openapi.diagnostic.Logger.error(Object) invocation
          Deprecated method com.intellij.openapi.diagnostic.Logger.error(java.lang.Object message) : void is invoked in io.flutter.vmService.VmServiceWrapper$10.onError(RPCError) : void

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested review from jwren and helin24 July 22, 2025 17:55
@pq pq merged commit 0979e12 into flutter:master Jul 22, 2025
8 checks passed
@pq pq deleted the cq_dep_Logger_error branch July 22, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants